RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:57:35 +00:00
Code Issues Activity Actions

LibJS: Add an initial implementation of Collator Compare Functions

Browse source 
This commit adds an initial implementation (without any real locale
support) of Collator Compare Functions, as well as the matching
CompareStrings AO. These two are used to implement the ECMA402 version
of String.localeCompare() and Int.Collator.compare().
This commit is contained in:
Idan Horowitz 2022-02-20 19:53:50 +02:00 • committed by Tim Flynn
parent 7feeb2df0d
commit 0bdb293262
3 changed files with 109 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

75
Userland/Libraries/LibJS/Runtime/Intl/CollatorCompareFunction.cpp Normal file
View file

@ -0,0 +1,75 @@
/*
* Copyright (c) 2022, Idan Horowitz <idan.horowitz@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <AK/Utf8View.h>
#include <LibJS/Runtime/GlobalObject.h>
#include <LibJS/Runtime/Intl/Collator.h>
#include <LibJS/Runtime/Intl/CollatorCompareFunction.h>
namespace JS::Intl {
CollatorCompareFunction* CollatorCompareFunction::create(GlobalObject& global_object, Collator& collator)
{
return global_object.heap().allocate<CollatorCompareFunction>(global_object, global_object, collator);
}
CollatorCompareFunction::CollatorCompareFunction(GlobalObject& global_object, Collator& collator)
: NativeFunction(*global_object.function_prototype())
, m_collator(collator)
{
}
void CollatorCompareFunction::initialize(GlobalObject& global_object)
{
auto& vm = global_object.vm();
define_direct_property(vm.names.length, Value(2), Attribute::Configurable);
}
// 10.3.3.2 CompareStrings ( collator, x, y ), https://tc39.es/ecma402/#sec-collator-comparestrings
double compare_strings(Collator& collator, Utf8View const& x, Utf8View const& y)
{
// FIXME: Implement https://unicode.org/reports/tr10
(void)collator;
auto x_iterator = x.begin();
auto y_iterator = y.begin();
for (; x_iterator != x.end() && y_iterator != y.end(); ++x_iterator, ++y_iterator) {
if (*x_iterator != *y_iterator)
return static_cast<double>(*x_iterator) - static_cast<double>(*y_iterator);
}
if (x_iterator != x.end())
return 1.0;
if (y_iterator != y.end())
return -1.0;
return 0.0;
}
// 10.3.3.1 Collator Compare Functions, https://tc39.es/ecma402/#sec-collator-compare-functions
ThrowCompletionOr<Value> CollatorCompareFunction::call()
{
auto& vm = this->vm();
auto& global_object = this->global_object();
// 1. Let collator be F.[[Collator]].
// 2. Assert: Type(collator) is Object and collator has an [[InitializedCollator]] internal slot.
// 3. If x is not provided, let x be undefined.
// 4. If y is not provided, let y be undefined.
// 5. Let X be ? ToString(x).
auto x = TRY(vm.argument(0).to_string(global_object));
// 6. Let Y be ? ToString(y).
auto y = TRY(vm.argument(1).to_string(global_object));
// 7. Return CompareStrings(collator, X, Y).
return compare_strings(m_collator, Utf8View(x), Utf8View(y));
}
void CollatorCompareFunction::visit_edges(Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(&m_collator);
}
}