RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 09:58:11 +00:00
Code Issues Activity Actions

LibTLS: Do not process_message() the finished message twice

Browse source 
With two different sequence numbers to boot!
Fixes #3273
This commit is contained in:
AnotherTest 2020-08-24 06:48:40 +04:30 • committed by Andreas Kling
parent 7a2b5d1328
commit 0be3937be7
2 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibTLS/ClientHandshake.cpp
View file

@ -216,7 +216,6 @@ ssize_t TLSv12::handle_finished(const ByteBuffer& buffer, WritePacketStage& writ
size_t index = 3;
u32 size = buffer[0] * 0x10000 + buffer[1] * 0x100 + buffer[2];
index += 3;
if (size < 12) {
#ifdef TLS_DEBUG
@ -248,7 +247,7 @@ ssize_t TLSv12::handle_finished(const ByteBuffer& buffer, WritePacketStage& writ
if (on_tls_ready_to_write)
on_tls_ready_to_write(*this);
return handle_message(buffer);
return index + size;
}
void TLSv12::build_random(PacketBuilder& builder)