RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 09:58:11 +00:00
Code Issues Activity Actions

Kernel: Mark sys$umount as not needing the big lock

Browse source 
All accesses to the mount table are already serialized by the actual
spinlock of that table.
This commit is contained in:
Liav A 2023-05-26 13:58:31 +03:00 • committed by Andreas Kling
parent 902dac7f5f
commit 0be79f9bc2
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/API/Syscall.h
View file

@ -193,7 +193,7 @@ enum class NeedsBigProcessLock {
S(sysconf, NeedsBigProcessLock::No) \ S(sysconf, NeedsBigProcessLock::No) \
S(times, NeedsBigProcessLock::No) \ S(times, NeedsBigProcessLock::No) \
S(umask, NeedsBigProcessLock::No) \ S(umask, NeedsBigProcessLock::No) \
S(umount, NeedsBigProcessLock::Yes) \ S(umount, NeedsBigProcessLock::No) \
S(uname, NeedsBigProcessLock::No) \ S(uname, NeedsBigProcessLock::No) \
S(unlink, NeedsBigProcessLock::No) \ S(unlink, NeedsBigProcessLock::No) \
S(unveil, NeedsBigProcessLock::No) \ S(unveil, NeedsBigProcessLock::No) \

2
Kernel/Syscalls/mount.cpp
View file

@ -161,7 +161,7 @@ ErrorOr<FlatPtr> Process::sys$bindmount(Userspace<Syscall::SC_bindmount_params c
ErrorOr<FlatPtr> Process::sys$umount(Userspace<char const*> user_mountpoint, size_t mountpoint_length) ErrorOr<FlatPtr> Process::sys$umount(Userspace<char const*> user_mountpoint, size_t mountpoint_length)
{ {
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); VERIFY_NO_PROCESS_BIG_LOCK(this);
auto credentials = this->credentials(); auto credentials = this->credentials();
if (!credentials->is_superuser()) if (!credentials->is_superuser())
return EPERM; return EPERM;