RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:18:11 +00:00
Code Issues Activity Actions

LibWeb: Fully implement end tag parsing in foreign content

Browse source 
Required to view the Spotify home page
This commit is contained in:
Luke 2021-01-02 23:02:23 +00:00 • committed by Andreas Kling
parent 306aff80d0
commit 0bf44ac9d8
1 changed files with 14 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Libraries/LibWeb/HTML/Parser/HTMLDocumentParser.cpp
View file

@ -2846,23 +2846,30 @@ void HTMLDocumentParser::process_using_the_rules_for_foreign_content(HTMLToken&
} }
if (token.is_end_tag()) { if (token.is_end_tag()) {
auto& node = current_node(); RefPtr<DOM::Element> node = current_node();
// FIXME: Not sure if this is the correct to_lowercase, as the specification says "to ASCII lowercase" // FIXME: Not sure if this is the correct to_lowercase, as the specification says "to ASCII lowercase"
if (node.tag_name().to_lowercase() != token.tag_name()) if (node->tag_name().to_lowercase() != token.tag_name())
PARSE_ERROR(); PARSE_ERROR();
while (true) { for (ssize_t i = m_stack_of_open_elements.elements().size() - 1; i >= 0; --i) {
if (&node == &m_stack_of_open_elements.first()) { if (node == m_stack_of_open_elements.first()) {
ASSERT(m_parsing_fragment); ASSERT(m_parsing_fragment);
return; return;
} }
// FIXME: See the above FIXME // FIXME: See the above FIXME
if (node.tag_name().to_lowercase() == token.tag_name()) { if (node->tag_name().to_lowercase() == token.tag_name()) {
while (&current_node() != &node) while (current_node() != node)
m_stack_of_open_elements.pop(); m_stack_of_open_elements.pop();
m_stack_of_open_elements.pop(); m_stack_of_open_elements.pop();
return; return;
} }
TODO();
node = m_stack_of_open_elements.elements().at(i - 1);
if (node->namespace_() != Namespace::HTML)
continue;
process_using_the_rules_for(m_insertion_mode, token);
return;
} }
} }