RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 06:48:12 +00:00
Code Issues Activity Actions

LibJS: Make string to number coercion work for doubles

Browse source
This commit is contained in:
Linus Groh 2020-05-13 00:04:52 +01:00 • committed by Andreas Kling
parent 7b8765c311
commit 0c14ee035c
2 changed files with 7 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Libraries/LibJS/Runtime/Value.cpp
View file

@ -173,13 +173,11 @@ Value Value::to_number() const
return js_infinity();
if (string == "-Infinity")
return js_negative_infinity();
bool ok;
//FIXME: Parse in a better way
auto parsed_int = string.to_int(ok);
if (ok)
return Value(parsed_int);
return js_nan();
char* endptr;
auto parsed_double = strtod(string.characters(), &endptr);
if (*endptr)
return js_nan();
return Value(parsed_double);
}
case Type::Object:
return m_value.as_object->to_primitive(Object::PreferredType::Number).to_number();