1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:37:37 +00:00

LibGUI+Everywhere: Use fallible Window::set_main_widget() everywhere :^)

Rip that bandaid off!

This does the following, in one big, awkward jump:
- Replace all uses of `set_main_widget<Foo>()` with the `try` version.
- Remove `set_main_widget<Foo>()`.
- Rename the `try` version to just be `set_main_widget` because it's now
  the only one.

The majority of places that call `set_main_widget<Foo>()` are inside
constructors, so this unfortunately gives us a big batch of new
`release_value_but_fixme_should_propagate_errors()` calls.
This commit is contained in:
Sam Atkins 2023-01-06 16:48:37 +00:00 committed by Andrew Kaster
parent d223477bc6
commit 0c24522635
121 changed files with 441 additions and 449 deletions

View file

@ -22,30 +22,30 @@ PasswordInputDialog::PasswordInputDialog(Window* parent_window, DeprecatedString
resize(340, 122);
set_title(move(title));
auto& widget = set_main_widget<Widget>();
auto widget = set_main_widget<Widget>().release_value_but_fixme_should_propagate_errors();
widget.load_from_gml(password_input_dialog_gml);
widget->load_from_gml(password_input_dialog_gml);
auto& key_icon_label = *widget.find_descendant_of_type_named<GUI::Label>("key_icon_label");
auto& key_icon_label = *widget->find_descendant_of_type_named<GUI::Label>("key_icon_label");
key_icon_label.set_icon(Gfx::Bitmap::try_load_from_file("/res/icons/32x32/key.png"sv).release_value_but_fixme_should_propagate_errors());
auto& server_label = *widget.find_descendant_of_type_named<GUI::Label>("server_label");
auto& server_label = *widget->find_descendant_of_type_named<GUI::Label>("server_label");
server_label.set_text(move(server));
auto& username_label = *widget.find_descendant_of_type_named<GUI::Label>("username_label");
auto& username_label = *widget->find_descendant_of_type_named<GUI::Label>("username_label");
username_label.set_text(move(username));
auto& password_box = *widget.find_descendant_of_type_named<GUI::PasswordBox>("password_box");
auto& password_box = *widget->find_descendant_of_type_named<GUI::PasswordBox>("password_box");
auto& ok_button = *widget.find_descendant_of_type_named<GUI::Button>("ok_button");
auto& ok_button = *widget->find_descendant_of_type_named<GUI::Button>("ok_button");
ok_button.on_click = [&](auto) {
dbgln("GUI::PasswordInputDialog: OK button clicked");
m_password = password_box.text();
done(ExecResult::OK);
};
auto& cancel_button = *widget.find_descendant_of_type_named<GUI::Button>("cancel_button");
auto& cancel_button = *widget->find_descendant_of_type_named<GUI::Button>("cancel_button");
cancel_button.on_click = [this](auto) {
dbgln("GUI::PasswordInputDialog: Cancel button clicked");
done(ExecResult::Cancel);