RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:37:46 +00:00
Code Issues Activity Actions

LibWeb: Don't replace existing Content-Type header in outgoing XHRs

Browse source 
This fixes an issue where Twitter was HTTP 400'ing some of our XHRs.
This commit is contained in:
Andreas Kling 2022-09-18 12:23:02 +02:00
parent 575e3bf37d
commit 0ca1b4b123
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/XHR/XMLHttpRequest.cpp
View file

@ -493,8 +493,11 @@ DOM::ExceptionOr<void> XMLHttpRequest::send(Optional<XMLHttpRequestBodyInit> bod
auto byte_buffer = TRY(ByteBuffer::copy(blob->bytes())); auto byte_buffer = TRY(ByteBuffer::copy(blob->bytes()));
request.set_body(byte_buffer); request.set_body(byte_buffer);
return {}; }, [](auto&) -> ErrorOr<void> { return {}; })); return {}; }, [](auto&) -> ErrorOr<void> { return {}; }));
if (body_with_type->type.has_value()) if (body_with_type->type.has_value()) {
request.set_header("Content-Type", String { body_with_type->type->span() }); // If type is non-null and this’s headers’s header list does not contain `Content-Type`, then append (`Content-Type`, type) to this’s headers.
if (!m_request_headers.contains("Content-Type"sv))
request.set_header("Content-Type", String { body_with_type->type->span() });
}
} }
for (auto& it : m_request_headers) for (auto& it : m_request_headers)
request.set_header(it.key, it.value); request.set_header(it.key, it.value);