From 0ca5a393d1fafe77570f551376177f5755c30f7a Mon Sep 17 00:00:00 2001 From: Gunnar Beutner Date: Tue, 15 Jun 2021 15:14:09 +0200 Subject: [PATCH] SystemServer: Improve error message when execv() fails Previously perror() would just tell us that the file specified for execv() doesn't exist. --- Userland/Services/SystemServer/Service.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Userland/Services/SystemServer/Service.cpp b/Userland/Services/SystemServer/Service.cpp index b3cb8fd8ed..cc712ecf29 100644 --- a/Userland/Services/SystemServer/Service.cpp +++ b/Userland/Services/SystemServer/Service.cpp @@ -234,7 +234,8 @@ void Service::spawn(int socket_fd) argv[m_extra_arguments.size() + 1] = nullptr; rc = execv(argv[0], argv); - perror("exec"); + warnln("Failed to execv({}, ...): {}", argv[0], strerror(errno)); + dbgln("Failed to execv({}, ...): {}", argv[0], strerror(errno)); VERIFY_NOT_REACHED(); } else if (!m_multi_instance) { // We are the parent.