RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 19:47:34 +00:00
Code Issues Activity Actions

LibWeb: Make BrowsingContextGroup & TraversableNavigable return a Page&

Browse source 
Removing another batch of uneeded null checks :^)
This commit is contained in:
Shannon Booth 2023-12-03 20:06:06 +13:00 • committed by Andreas Kling
parent 88f8ea7c60
commit 0cb0d60ac5
8 changed files with 13 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -1900,10 +1900,7 @@ void Document::update_readiness(HTML::DocumentReadyState readiness_value)
if (readiness_value == HTML::DocumentReadyState::Complete && is_active() && navigable()->is_traversable()) {
HTML::HTMLLinkElement::load_fallback_favicon_if_needed(*this).release_value_but_fixme_should_propagate_errors();
if (auto* page = navigable()->traversable_navigable()->page()) {
page->client().page_did_finish_loading(url());
}
navigable()->traversable_navigable()->page().client().page_did_finish_loading(url());
}
}

4
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -1668,8 +1668,8 @@ static ErrorOr<void> scroll_an_element_into_view(DOM::Element& target, Bindings:
(void)behavior;
// AD-HOC:
auto* page = document.navigable()->traversable_navigable()->page();
page->client().page_did_request_scroll_to(position.location());
auto& page = document.navigable()->traversable_navigable()->page();
page.client().page_did_request_scroll_to(position.location());
}
// If scrolling box is associated with an element
else {