RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:17:34 +00:00
Code Issues Activity Actions

Kernel: Mark Lock getters as [[nodiscard]]

Browse source 
There is no reason to call a getter without observing the result, doing
so indicates an error in the code. Mark these methods as [[nodiscard]]
to find these cases.
This commit is contained in:
Brian Gianforcaro 2021-02-14 15:24:44 -08:00 • committed by Andreas Kling
parent a75d7958cc
commit 0cbede91b8
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Kernel/Lock.h
View file

@ -58,10 +58,10 @@ public:
void unlock(); void unlock();
[[nodiscard]] Mode force_unlock_if_locked(u32&); [[nodiscard]] Mode force_unlock_if_locked(u32&);
void restore_lock(Mode, u32); void restore_lock(Mode, u32);
bool is_locked() const { return m_mode != Mode::Unlocked; } [[nodiscard]] bool is_locked() const { return m_mode != Mode::Unlocked; }
void clear_waiters(); void clear_waiters();
const char* name() const { return m_name; } [[nodiscard]] const char* name() const { return m_name; }
static const char* mode_to_string(Mode mode) static const char* mode_to_string(Mode mode)
{ {
@ -149,10 +149,10 @@ public:
: m_resource(move(resource)) : m_resource(move(resource))
{ {
} }
Lock& lock() { return m_lock; } [[nodiscard]] Lock& lock() { return m_lock; }
T& resource() { return m_resource; } [[nodiscard]] T& resource() { return m_resource; }
T lock_and_copy() [[nodiscard]] T lock_and_copy()
{ {
LOCKER(m_lock); LOCKER(m_lock);
return m_resource; return m_resource;