RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:27:45 +00:00
Code Issues Activity Actions

LibJS: Use move semantics more when creating Reference objects

Browse source 
Turns a bunch of FlyString copies into moves.
This commit is contained in:
Andreas Kling 2021-09-11 19:03:38 +02:00
parent 6704961c82
commit 0d2c3f62d3
5 changed files with 18 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibJS/Runtime/VM.cpp
View file

@ -403,12 +403,12 @@ Value VM::get_variable(const FlyString& name, GlobalObject& global_object)
}
// 9.1.2.1 GetIdentifierReference ( env, name, strict ), https://tc39.es/ecma262/#sec-getidentifierreference
Reference VM::get_identifier_reference(Environment* environment, FlyString const& name, bool strict)
Reference VM::get_identifier_reference(Environment* environment, FlyString name, bool strict)
{
// 1. If env is the value null, then
if (!environment) {
// a. Return the Reference Record { [[Base]]: unresolvable, [[ReferencedName]]: name, [[Strict]]: strict, [[ThisValue]]: empty }.
return Reference { Reference::BaseType::Unresolvable, name, strict };
return Reference { Reference::BaseType::Unresolvable, move(name), strict };
}
// FIXME: The remainder of this function is non-conforming.
@ -417,14 +417,14 @@ Reference VM::get_identifier_reference(Environment* environment, FlyString const
for (; environment && environment->outer_environment(); environment = environment->outer_environment()) {
auto possible_match = environment->get_from_environment(name);
if (possible_match.has_value())
return Reference { *environment, name, strict };
return Reference { *environment, move(name), strict };
}
if (global_object.environment().has_binding(name) || !in_strict_mode()) {
return Reference { global_object.environment(), name, strict };
return Reference { global_object.environment(), move(name), strict };
}
return Reference { Reference::BaseType::Unresolvable, name, strict };
return Reference { Reference::BaseType::Unresolvable, move(name), strict };
}
// 9.4.2 ResolveBinding ( name [ , env ] ), https://tc39.es/ecma262/#sec-resolvebinding