RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 06:17:34 +00:00
Code Issues Activity Actions

SpaceAnalyzer: Make sure data fields of TreeNode are encapsulated

Browse source 
Made the member fields of Tree and TreeNode structures private and moved
the functions in main.cpp that accessed the internals of these
structures inside the TreeNode class
This commit is contained in:
Arda Cinar 2022-12-13 11:03:05 +03:00 • committed by Sam Atkins
parent 8ba37872e9
commit 0d67e60559
3 changed files with 137 additions and 121 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Userland/Applications/SpaceAnalyzer/Tree.h
View file

@ -12,7 +12,13 @@
#include <AK/RefCounted.h>
#include <AK/Vector.h>
struct TreeNode final {
struct MountInfo {
DeprecatedString mount_point;
DeprecatedString source;
};
class TreeNode final {
public:
TreeNode(DeprecatedString name)
: m_name(move(name)) {};
@ -27,19 +33,26 @@ struct TreeNode final {
}
TreeNode const& child_at(size_t i) const { return m_children->at(i); }
void sort_children_by_area() const;
HashMap<int, int> populate_filesize_tree(Vector<MountInfo>& mounts, Function<void(size_t)> on_progress);
private:
long long int update_totals();
DeprecatedString m_name;
i64 m_area { 0 };
OwnPtr<Vector<TreeNode>> m_children;
};
struct Tree : public RefCounted<Tree> {
class Tree : public RefCounted<Tree> {
public:
Tree(DeprecatedString root_name)
: m_root(move(root_name)) {};
~Tree() {};
TreeNode m_root;
TreeNode const& root() const
TreeNode& root()
{
return m_root;
};
private:
TreeNode m_root;
};