RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:57:44 +00:00
Code Issues Activity Actions

LibWeb: Make ResizeObserver GC-allocated

Browse source
This commit is contained in:
Andreas Kling 2022-09-04 13:33:07 +02:00
parent 915a240944
commit 0dc2c27fa3
4 changed files with 24 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibWeb/Forward.h
View file

@ -453,7 +453,6 @@ class IntersectionObserverWrapper;
class LocationObject; class LocationObject;
class OptionConstructor; class OptionConstructor;
class RangePrototype; class RangePrototype;
class ResizeObserverWrapper;
class URLSearchParamsIteratorWrapper; class URLSearchParamsIteratorWrapper;
class URLSearchParamsWrapper; class URLSearchParamsWrapper;
class URLWrapper; class URLWrapper;

13
Userland/Libraries/LibWeb/ResizeObserver/ResizeObserver.cpp
View file

@ -5,18 +5,27 @@
*/ */
#include <LibWeb/DOM/Element.h> #include <LibWeb/DOM/Element.h>
#include <LibWeb/HTML/Window.h>
#include <LibWeb/ResizeObserver/ResizeObserver.h> #include <LibWeb/ResizeObserver/ResizeObserver.h>
namespace Web::ResizeObserver { namespace Web::ResizeObserver {
// https://drafts.csswg.org/resize-observer/#dom-resizeobserver-resizeobserver // https://drafts.csswg.org/resize-observer/#dom-resizeobserver-resizeobserver
NonnullRefPtr<ResizeObserver> ResizeObserver::create_with_global_object(HTML::Window&, Bindings::CallbackType* callback) JS::NonnullGCPtr<ResizeObserver> ResizeObserver::create_with_global_object(HTML::Window& window, Bindings::CallbackType* callback)
{ {
// FIXME: Implement // FIXME: Implement
(void)callback; (void)callback;
return adopt_ref(*new ResizeObserver); return *window.heap().allocate<ResizeObserver>(window.realm(), window);
} }
ResizeObserver::ResizeObserver(HTML::Window& window)
: PlatformObject(window.realm())
{
set_prototype(&window.cached_web_prototype("ResizeObserver"));
}
ResizeObserver::~ResizeObserver() = default;
// https://drafts.csswg.org/resize-observer/#dom-resizeobserver-observe // https://drafts.csswg.org/resize-observer/#dom-resizeobserver-observe
void ResizeObserver::observe(DOM::Element& target, ResizeObserverOptions options) void ResizeObserver::observe(DOM::Element& target, ResizeObserverOptions options)
{ {

22
Userland/Libraries/LibWeb/ResizeObserver/ResizeObserver.h
View file

@ -6,10 +6,7 @@
#pragma once #pragma once
#include <AK/NonnullRefPtr.h> #include <LibWeb/Bindings/PlatformObject.h>
#include <AK/RefCounted.h>
#include <LibWeb/Bindings/Wrappable.h>
#include <LibWeb/Forward.h>
namespace Web::ResizeObserver { namespace Web::ResizeObserver {
@ -18,17 +15,22 @@ struct ResizeObserverOptions {
}; };
// https://drafts.csswg.org/resize-observer/#resize-observer-interface // https://drafts.csswg.org/resize-observer/#resize-observer-interface
class ResizeObserver class ResizeObserver : public Bindings::PlatformObject {
: public RefCounted<ResizeObserver> WEB_PLATFORM_OBJECT(ResizeObserver, Bindings::PlatformObject);
, public Bindings::Wrappable {
public:
using WrapperType = Bindings::ResizeObserverWrapper;
static NonnullRefPtr<ResizeObserver> create_with_global_object(HTML::Window&, Bindings::CallbackType* callback); public:
static JS::NonnullGCPtr<ResizeObserver> create_with_global_object(HTML::Window&, Bindings::CallbackType* callback);
virtual ~ResizeObserver() override;
void observe(DOM::Element& target, ResizeObserverOptions); void observe(DOM::Element& target, ResizeObserverOptions);
void unobserve(DOM::Element& target); void unobserve(DOM::Element& target);
void disconnect(); void disconnect();
private:
explicit ResizeObserver(HTML::Window&);
}; };
} }
WRAPPER_HACK(ResizeObserver, Web::ResizeObserver)

2
Userland/Libraries/LibWeb/idl_files.cmake
View file

@ -158,7 +158,7 @@ libweb_js_wrapper(HighResolutionTime/Performance NO_INSTANCE)
libweb_js_wrapper(IntersectionObserver/IntersectionObserver) libweb_js_wrapper(IntersectionObserver/IntersectionObserver)
libweb_js_wrapper(NavigationTiming/PerformanceTiming NO_INSTANCE) libweb_js_wrapper(NavigationTiming/PerformanceTiming NO_INSTANCE)
libweb_js_wrapper(RequestIdleCallback/IdleDeadline NO_INSTANCE) libweb_js_wrapper(RequestIdleCallback/IdleDeadline NO_INSTANCE)
libweb_js_wrapper(ResizeObserver/ResizeObserver) libweb_js_wrapper(ResizeObserver/ResizeObserver NO_INSTANCE)
libweb_js_wrapper(SVG/SVGAnimatedLength NO_INSTANCE) libweb_js_wrapper(SVG/SVGAnimatedLength NO_INSTANCE)
libweb_js_wrapper(SVG/SVGClipPathElement NO_INSTANCE) libweb_js_wrapper(SVG/SVGClipPathElement NO_INSTANCE)
libweb_js_wrapper(SVG/SVGDefsElement NO_INSTANCE) libweb_js_wrapper(SVG/SVGDefsElement NO_INSTANCE)