RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 21:27:34 +00:00
Code Issues Activity Actions

LibVT: Always check intermediate bytes in CSI sequences

Browse source 
Previously, we only checked the intermediate bytes for those escape
sequences that performed different operations based on their
intermediate bytes. This lead to a crash when `CSI ?1001 r` was
incorrectly parsed as `CSI Pt ; Pb r` (note the missing question mark),
as seen in #8559.
This commit is contained in:
Daniel Bertalan 2021-07-09 12:08:36 +02:00 • committed by Ali Mohammad Pur
parent 52aa777d49
commit 0e04f7cf1e
2 changed files with 201 additions and 213 deletions
Download patch file Download diff file Expand all files Collapse all files

185
Userland/Libraries/LibVT/Terminal.cpp
View file

@ -48,7 +48,19 @@ void Terminal::clear_history()
} }
#endif #endif
void Terminal::alter_mode(bool should_set, Parameters params, Intermediates intermediates) void Terminal::alter_ansi_mode(bool should_set, Parameters params)
{
for (auto mode : params) {
switch (mode) {
// FIXME: implement *something* for this
default:
dbgln("Terminal::alter_ansi_mode: Unimplemented mode {} (should_set={})", mode, should_set);
break;
}
}
}
void Terminal::alter_private_mode(bool should_set, Parameters params)
{ {
auto steady_cursor_to_blinking = [](CursorStyle style) { auto steady_cursor_to_blinking = [](CursorStyle style) {
switch (style) { switch (style) {
@ -76,7 +88,6 @@ void Terminal::alter_mode(bool should_set, Parameters params, Intermediates inte
} }
}; };
if (intermediates.size() > 0 && intermediates[0] == '?') {
for (auto mode : params) { for (auto mode : params) {
switch (mode) { switch (mode) {
case 3: { case 3: {
@ -153,30 +164,30 @@ void Terminal::alter_mode(bool should_set, Parameters params, Intermediates inte
m_needs_bracketed_paste = should_set; m_needs_bracketed_paste = should_set;
break; break;
default: default:
dbgln("Terminal::alter_mode: Unimplemented private mode {} (should_set={})", mode, should_set); dbgln("Terminal::alter_private_mode: Unimplemented private mode {} (should_set={})", mode, should_set);
break; break;
} }
} }
} else {
for (auto mode : params) {
switch (mode) {
// FIXME: implement *something* for this
default:
dbgln("Terminal::alter_mode: Unimplemented mode {} (should_set={})", mode, should_set);
break;
}
}
}
} }
void Terminal::RM(Parameters params, Intermediates intermediates) void Terminal::RM(Parameters params)
{ {
alter_mode(false, params, intermediates); alter_ansi_mode(false, params);
} }
void Terminal::SM(Parameters params, Intermediates intermediates) void Terminal::DECRST(Parameters params)
{ {
alter_mode(true, params, intermediates); alter_private_mode(false, params);
}
void Terminal::SM(Parameters params)
{
alter_ansi_mode(true, params);
}
void Terminal::DECSET(Parameters params)
{
alter_private_mode(true, params);
} }
void Terminal::SGR(Parameters params) void Terminal::SGR(Parameters params)
@ -1085,124 +1096,95 @@ void Terminal::execute_csi_sequence(Parameters parameters, Intermediates interme
if (ignore) if (ignore)
dbgln("CSI sequence has its ignore flag set."); dbgln("CSI sequence has its ignore flag set.");
if (intermediates.is_empty()) {
switch (last_byte) { switch (last_byte) {
case '@': case '@':
ICH(parameters); return ICH(parameters);
break;
case 'A': case 'A':
CUU(parameters); return CUU(parameters);
break;
case 'B': case 'B':
CUD(parameters); return CUD(parameters);
break;
case 'C': case 'C':
CUF(parameters); return CUF(parameters);
break;
case 'D': case 'D':
CUB(parameters); return CUB(parameters);
break;
case 'E': case 'E':
CNL(parameters); return CNL(parameters);
break;
case 'F': case 'F':
CPL(parameters); return CPL(parameters);
break;
case 'G': case 'G':
CHA(parameters); return CHA(parameters);
break;
case 'H': case 'H':
CUP(parameters); return CUP(parameters);
break;
case 'J': case 'J':
ED(parameters); return ED(parameters);
break;
case 'K': case 'K':
EL(parameters); return EL(parameters);
break;
case 'L': case 'L':
IL(parameters); return IL(parameters);
break;
case 'M': case 'M':
DL(parameters); return DL(parameters);
break;
case 'P': case 'P':
DCH(parameters); return DCH(parameters);
break;
case 'S': case 'S':
SU(parameters); return SU(parameters);
break;
case 'T': case 'T':
SD(parameters); return SD(parameters);
break;
case 'X': case 'X':
ECH(parameters); return ECH(parameters);
break;
case '`': case '`':
HPA(parameters); return HPA(parameters);
break;
case 'a': case 'a':
HPR(parameters); return HPR(parameters);
break;
case 'b': case 'b':
REP(parameters); return REP(parameters);
break;
case 'c': case 'c':
DA(parameters); return DA(parameters);
break;
case 'd': case 'd':
VPA(parameters); return VPA(parameters);
break;
case 'e': case 'e':
VPR(parameters); return VPR(parameters);
break;
case 'f': case 'f':
HVP(parameters); return HVP(parameters);
break;
case 'h': case 'h':
SM(parameters, intermediates); return SM(parameters);
break;
case 'l': case 'l':
RM(parameters, intermediates); return RM(parameters);
break;
case 'm': case 'm':
SGR(parameters); return SGR(parameters);
break;
case 'n': case 'n':
DSR(parameters); return DSR(parameters);
break;
case 'q':
if (intermediates.size() >= 1 && intermediates[0] == ' ')
DECSCUSR(parameters);
else
unimplemented_csi_sequence(parameters, intermediates, last_byte);
break;
case 'r': case 'r':
DECSTBM(parameters); return DECSTBM(parameters);
break;
case 's': case 's':
SCOSC(); return SCOSC();
break;
case 't': case 't':
XTERM_WM(parameters); return XTERM_WM(parameters);
break;
case 'u': case 'u':
SCORC(); return SCORC();
break;
case '}':
if (intermediates.size() >= 1 && intermediates[0] == '\'')
DECIC(parameters);
else
unimplemented_csi_sequence(parameters, intermediates, last_byte);
break;
case '~':
if (intermediates.size() >= 1 && intermediates[0] == '\'')
DECDC(parameters);
else
unimplemented_csi_sequence(parameters, intermediates, last_byte);
break;
default:
unimplemented_csi_sequence(parameters, intermediates, last_byte);
} }
} else if (intermediates.size() == 1 && intermediates[0] == '?') {
switch (last_byte) {
case 'h':
return DECSET(parameters);
case 'l':
return DECRST(parameters);
}
} else if (intermediates.size() == 1 && intermediates[0] == '\'') {
switch (last_byte) {
case '}':
return DECIC(parameters);
case '~':
return DECDC(parameters);
}
} else if (intermediates.size() == 1 && intermediates[0] == ' ') {
switch (last_byte) {
case 'q':
return DECSCUSR(parameters);
}
}
unimplemented_csi_sequence(parameters, intermediates, last_byte);
} }
void Terminal::execute_osc_sequence(OscParameters parameters, u8 last_byte) void Terminal::execute_osc_sequence(OscParameters parameters, u8 last_byte)
@ -1603,5 +1585,4 @@ Attribute Terminal::attribute_at(const Position& position) const
return line.attribute_at(position.column()); return line.attribute_at(position.column());
} }
#endif #endif
} }

13
Userland/Libraries/LibVT/Terminal.h
View file

@ -226,7 +226,8 @@ protected:
void emit_string(const StringView&); void emit_string(const StringView&);
void alter_mode(bool should_set, Parameters, Intermediates); void alter_ansi_mode(bool should_set, Parameters);
void alter_private_mode(bool should_set, Parameters);
// CUU – Cursor Up // CUU – Cursor Up
void CUU(Parameters); void CUU(Parameters);
@ -274,10 +275,16 @@ protected:
void DECSTBM(Parameters); void DECSTBM(Parameters);
// RM – Reset Mode // RM – Reset Mode
void RM(Parameters, Intermediates); void RM(Parameters);
// DECRST - DEC Private Mode Reset
void DECRST(Parameters);
// SM – Set Mode // SM – Set Mode
void SM(Parameters, Intermediates); void SM(Parameters);
// DECSET - Dec Private Mode Set
void DECSET(Parameters);
// DA - Device Attributes // DA - Device Attributes
void DA(Parameters); void DA(Parameters);