RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:17:35 +00:00
Code Issues Activity Actions

Kernel: Remove the per-process icon_id and sys$set_process_icon()

Browse source 
This was a goofy kernel API where you could assign an icon_id (int) to
a process which referred to a global shbuf with a 16x16 icon bitmap
inside it.

Instead of this, programs that want to display a process icon now
retrieve it from the process executable instead.
This commit is contained in:
Andreas Kling 2020-12-27 01:13:23 +01:00
parent cb68b8ff8b
commit 0e2b7f9c9a
12 changed files with 0 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibC/unistd.cpp
View file

@ -550,12 +550,6 @@ void sync()
syscall(SC_sync);
}
int set_process_icon(int icon_id)
{
int rc = syscall(SC_set_process_icon, icon_id);
__RETURN_WITH_ERRNO(rc, rc, -1);
}
static String getlogin_buffer;
char* getlogin()

1
Libraries/LibC/unistd.h
View file

@ -61,7 +61,6 @@ int fsync(int fd);
void sysbeep();
int gettid();
int donate(int tid);
int set_process_icon(int icon_id);
int getpagesize();
pid_t fork();
int execv(const char* path, char* const argv[]);

1
Libraries/LibCore/ProcessStatisticsReader.cpp
View file

@ -75,7 +75,6 @@ HashMap<pid_t, Core::ProcessStatistics> ProcessStatisticsReader::get_all()
process.amount_clean_inode = process_object.get("amount_clean_inode").to_u32();
process.amount_purgeable_volatile = process_object.get("amount_purgeable_volatile").to_u32();
process.amount_purgeable_nonvolatile = process_object.get("amount_purgeable_nonvolatile").to_u32();
process.icon_id = process_object.get("icon_id").to_int();
auto& thread_array = process_object.get_ptr("threads")->as_array();
process.threads.ensure_capacity(thread_array.size());

1
Libraries/LibCore/ProcessStatisticsReader.h
View file

@ -77,7 +77,6 @@ struct ProcessStatistics {
size_t amount_clean_inode;
size_t amount_purgeable_volatile;
size_t amount_purgeable_nonvolatile;
int icon_id;
Vector<Core::ThreadStatistics> threads;

4
Libraries/LibGUI/Window.cpp
View file

@ -721,10 +721,6 @@ void Window::apply_icon()
rc = shbuf_allow_all(m_icon->shbuf_id());
ASSERT(rc == 0);
static bool has_set_process_icon;
if (!has_set_process_icon)
set_process_icon(m_icon->shbuf_id());
WindowServerConnection::the().send_sync<Messages::WindowServer::SetWindowIconBitmap>(m_window_id, m_icon->to_shareable_bitmap(WindowServerConnection::the().server_pid()));
}