RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:17:44 +00:00
Code Issues Activity Actions

Kernel: Use unsigned instead of signed types in SerialDevice

Browse source 
Addresses are unsigned by definition, and the conversion from signed
to unsigned and back in SerialDevice looked a bit dubious.
This commit is contained in:
Idan Horowitz 2021-04-23 17:25:07 +03:00 • committed by Andreas Kling
parent 3ad0a0d8c3
commit 0e5aba16ef
2 changed files with 23 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

30
Kernel/Devices/SerialDevice.h
View file

@ -18,7 +18,7 @@ namespace Kernel {
class SerialDevice final : public CharacterDevice {
AK_MAKE_ETERNAL
public:
SerialDevice(int base_addr, unsigned minor);
SerialDevice(u32 base_addr, unsigned minor);
virtual ~SerialDevice() override;
// ^CharacterDevice
@ -112,25 +112,23 @@ private:
virtual const char* class_name() const override { return "SerialDevice"; }
void initialize();
void set_interrupts(char interrupt_enable);
void set_interrupts(bool interrupt_enable);
void set_baud(Baud);
void set_fifo_control(char fifo_control);
void set_fifo_control(u8 fifo_control);
void set_line_control(ParitySelect, StopBits, WordLength);
void set_break_enable(bool break_enable);
void set_modem_control(char modem_control);
char get_line_status() const;
bool rx_ready();
bool tx_ready();
void set_modem_control(u8 modem_control);
u8 get_line_status() const;
int m_base_addr;
char m_interrupt_enable;
char m_fifo_control;
Baud m_baud;
ParitySelect m_parity_select;
StopBits m_stop_bits;
WordLength m_word_length;
bool m_break_enable;
char m_modem_control;
u32 m_base_addr { 0 };
bool m_interrupt_enable { false };
u8 m_fifo_control { 0 };
Baud m_baud { Baud38400 };
ParitySelect m_parity_select { None };
StopBits m_stop_bits { One };
WordLength m_word_length { EightBits };
bool m_break_enable { false };
u8 m_modem_control { 0 };
};
}