RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:17:34 +00:00
Code Issues Activity Actions

LibJS: Convert internal_get_own_property() to ThrowCompletionOr

Browse source
This commit is contained in:
Linus Groh 2021-09-29 17:53:57 +01:00
parent 73bae7d779
commit 0e69a6e487
19 changed files with 100 additions and 166 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Userland/Libraries/LibJS/Runtime/GlobalEnvironment.cpp
View file

@ -142,11 +142,8 @@ bool GlobalEnvironment::has_lexical_declaration(FlyString const& name) const
// 9.1.1.4.14 HasRestrictedGlobalProperty ( N ), https://tc39.es/ecma262/#sec-hasrestrictedglobalproperty
bool GlobalEnvironment::has_restricted_global_property(FlyString const& name) const
{
auto& vm = this->vm();
auto& global_object = m_object_record->binding_object();
auto existing_prop = global_object.internal_get_own_property(name);
if (vm.exception())
return {};
auto existing_prop = TRY_OR_DISCARD(global_object.internal_get_own_property(name));
if (!existing_prop.has_value())
return false;
if (*existing_prop->configurable)
@ -170,11 +167,8 @@ bool GlobalEnvironment::can_declare_global_var(FlyString const& name) const
// 9.1.1.4.16 CanDeclareGlobalFunction ( N ), https://tc39.es/ecma262/#sec-candeclareglobalfunction
bool GlobalEnvironment::can_declare_global_function(FlyString const& name) const
{
auto& vm = this->vm();
auto& global_object = m_object_record->binding_object();
auto existing_prop = global_object.internal_get_own_property(name);
if (vm.exception())
return {};
auto existing_prop = TRY_OR_DISCARD(global_object.internal_get_own_property(name));
if (!existing_prop.has_value())
return global_object.is_extensible();
if (*existing_prop->configurable)
@ -212,9 +206,10 @@ void GlobalEnvironment::create_global_function_binding(FlyString const& name, Va
{
auto& vm = this->vm();
auto& global_object = m_object_record->binding_object();
auto existing_prop = global_object.internal_get_own_property(name);
if (vm.exception())
auto existing_prop_or_error = global_object.internal_get_own_property(name);
if (existing_prop_or_error.is_error())
return;
auto existing_prop = existing_prop_or_error.release_value();
PropertyDescriptor desc;
if (!existing_prop.has_value() || *existing_prop->configurable)
desc = { .value = value, .writable = true, .enumerable = true, .configurable = can_be_deleted };