RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:37:35 +00:00
Code Issues Activity Actions

Kernel: Make ptrace return an error on error

Browse source 
Returning 'result.error().code()' erroneously creates an
ErrorOr<FlatPtr> of the positive errno code, which breaks our
error-returning convention.

This seems to be due to a forgotten minus-sign during the refactoring in
9e51e295cf. This latent bug was never
discovered, because currently the error-handling paths are rarely
exercised.
This commit is contained in:
Ben Wiederhake 2021-11-27 11:22:25 +01:00 • committed by Andreas Kling
parent 49adebf0fc
commit 0e6e1092f0
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Kernel/Syscalls/ptrace.cpp
View file

@ -162,8 +162,7 @@ ErrorOr<FlatPtr> Process::sys$ptrace(Userspace<const Syscall::SC_ptrace_params*>
REQUIRE_PROMISE(ptrace); REQUIRE_PROMISE(ptrace);
auto params = TRY(copy_typed_from_user(user_params)); auto params = TRY(copy_typed_from_user(user_params));
auto result = handle_ptrace(params, *this); return handle_ptrace(params, *this);
return result.is_error() ? result.error().code() : result.value();
} }
/** /**