RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-20 13:45:06 +00:00
Code Issues Activity Actions

LibWebView+WebContent: Begin handling open user dialogs for WebDriver

Browse source 
The way in which dialogs should be handled is configurable by the driver
capabilities object, which we don't support yet. So this implements just
the default mode to dismiss the dialog and return an error if there is
one open.

In the OOPWV, this means we need to refer to the dialog after it has
been open, so we now hold a pointer to whatever dialog is open.
This commit is contained in:
Timothy Flynn 2022-11-16 06:58:14 -05:00 • committed by Linus Groh
parent 5b31a3dbc7
commit 0e94904034
10 changed files with 165 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWebView/WebContentClient.cpp
View file

@ -191,6 +191,16 @@ void WebContentClient::did_request_prompt(String const& message, String const& d
m_view.notify_server_did_request_prompt({}, message, default_);
}
void WebContentClient::did_request_accept_dialog()
{
m_view.notify_server_did_request_accept_dialog({});
}
void WebContentClient::did_request_dismiss_dialog()
{
m_view.notify_server_did_request_dismiss_dialog({});
}
void WebContentClient::did_change_favicon(Gfx::ShareableBitmap const& favicon)
{
if (!favicon.is_valid()) {