From 0eb7c24e7d812bdd37a709e54bad3939ffcc6d4f Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sat, 6 May 2023 12:42:22 +0200 Subject: [PATCH] Ladybird: Stop telling Qt to use HTTP pipelining For some reason, this was causing incomplete HTTP loads in some cases. As an example, we would only load half of the "Ahem" CSS font from the wpt.live server when running Acid3. I only enabled pipelining in the first place because I assumed it would be a performance boost, but it appears to do more than that. I suppose there's a reason it's off by default (and most Qt API users don't bother enabling it.) --- Ladybird/RequestManagerQt.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/Ladybird/RequestManagerQt.cpp b/Ladybird/RequestManagerQt.cpp index e6a97d2f15..7138243e89 100644 --- a/Ladybird/RequestManagerQt.cpp +++ b/Ladybird/RequestManagerQt.cpp @@ -40,7 +40,6 @@ ErrorOr> RequestManagerQt::Request::cre { QNetworkRequest request { QString(url.to_deprecated_string().characters()) }; request.setAttribute(QNetworkRequest::RedirectPolicyAttribute, QNetworkRequest::ManualRedirectPolicy); - request.setAttribute(QNetworkRequest::HttpPipeliningAllowedAttribute, true); request.setAttribute(QNetworkRequest::CookieLoadControlAttribute, QNetworkRequest::Manual); request.setAttribute(QNetworkRequest::CookieSaveControlAttribute, QNetworkRequest::Manual);