RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 23:27:44 +00:00
Code Issues Activity Actions

LibWeb: Don't infer SVG viewBox if width and/or height is zero

Browse source 
The fix here has two parts:
1. Don't use the fallback viewBox at all if we're not in SVG-as-image.
2. Don't make a fallback viewBox with zero width and/or height.

This fixes a crash on Bandcamp pages. Thanks Tim Flynn for reporting!
This commit is contained in:
Andreas Kling 2023-06-20 19:55:53 +02:00
parent ffd5b3da16
commit 0ec522ab54
4 changed files with 31 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Tests/LibWeb/Layout/input/svg/svg-with-zero-intrinsic-size-and-no-viewbox.html Normal file
View file

@ -0,0 +1,4 @@
<img src="svg-with-zero-intrinsic-size-and-no-viewbox.svg">
<svg width=0 height=0>
<rect x=0 y=0 width=1 height=1 />
</svg>

3
Tests/LibWeb/Layout/input/svg/svg-with-zero-intrinsic-size-and-no-viewbox.svg Normal file
View file

@ -0,0 +1,3 @@
<svg width=0 height=0>
<rect x=0 y=0 width=1 height=1 />
</svg>
Side by side

After

Width:  |  Height:  |  Size: 68 B