RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 21:37:35 +00:00
Code Issues Activity Actions

LibWeb: Add virtual to check if a Navigable is a top level traversable

Browse source 
This avoids some AK::is casting when we need to check this property in
upcoming algorithms.
This commit is contained in:
Andrew Kaster 2023-08-28 18:00:52 +02:00 • committed by Alexander Kalenik
parent 0c85a7cebc
commit 0ed67fc0ce
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/Navigable.h
View file

@ -66,6 +66,8 @@ public:
JS::GCPtr<TraversableNavigable> traversable_navigable() const;
JS::GCPtr<TraversableNavigable> top_level_traversable();
virtual bool is_top_level_traversable() const { return false; }
enum class WindowType {
ExistingOrNone,
NewAndUnrestricted,

2
Userland/Libraries/LibWeb/HTML/TraversableNavigable.h
View file

@ -23,7 +23,7 @@ public:
virtual ~TraversableNavigable() override;
bool is_top_level_traversable() const;
virtual bool is_top_level_traversable() const override;
int current_session_history_step() const { return m_current_session_history_step; }
Vector<JS::NonnullGCPtr<SessionHistoryEntry>>& session_history_entries() { return m_session_history_entries; }