RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 22:27:35 +00:00
Code Issues Activity Actions

LibCompress: Brotli support metadata of skip_length=0

Browse source 
The relevant RFC section from
https://www.rfc-editor.org/rfc/rfc7932#section-9.2

MSKIPBYTES * 8 bits: MSKIPLEN - 1, where MSKIPLEN is
       the number of metadata bytes; this field is
       only present if MSKIPBYTES is positive;
       otherwise, MSKIPLEN is 0 (if MSKIPBYTES is
       greater than 1, and the last byte is all
       zeros, then the stream should be rejected as
       invalid)

So when skip_bytes is zero we need to break and
re-align bytes.

Added the relevant test case that demonstrates this from:
https://github.com/google/brotli/blob/master/tests/testdata/x.compressed
This commit is contained in:
Tommy Murphy 2022-09-18 13:38:07 -04:00 • committed by Andrew Kaster
parent 7ea987456a
commit 0ee98c69c1
4 changed files with 53 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Tests/LibCompress/TestBrotli.cpp
View file

@ -80,6 +80,11 @@ TEST_CASE(brotli_single_z)
run_test("single-z.txt"sv);
}
TEST_CASE(brotli_single_x)
{
run_test("single-x.txt"sv);
}
TEST_CASE(brotli_decompress_zero_one_bin)
{
// This makes sure that the tests will run both on target and in Lagom.