RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:37:34 +00:00
Code Issues Activity Actions

LibWeb: Fix bogus min/max-height for box-sizing:border-box flex items

Browse source 
When resolving these constraints to CSS pixel sizes, we have to resolve
padding-top and padding-bottom against the flex container's *width*,
not its height.
This commit is contained in:
Andreas Kling 2023-03-10 11:54:52 +01:00
parent 24d5a9d7df
commit 0ef07383e5
3 changed files with 38 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Tests/LibWeb/Layout/expected/flex-item-vertical-padding-relative-to-flex-container-width.txt Normal file
View file

@ -0,0 +1,15 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x30 children: not-inline
BlockContainer <body> at (10,10) content-size 780x12 children: not-inline
BlockContainer <(anonymous)> at (10,10) content-size 780x0 children: inline
TextNode <#text>
Box <div.flex-container> at (11,11) content-size 600x10 flex-container(row) children: not-inline
BlockContainer <(anonymous)> at (11,11) content-size 0x0 children: inline
TextNode <#text>
BlockContainer <div.flex-item> at (12,72) content-size 24.859375x18.000007 flex-item children: inline
line 0 width: 24.859375, height: 19.359375, bottom: 19.359375, baseline: 15.5
frag 0 from TextNode start: 0, length: 3, rect: [12,72 24.859375x19.359375]
"foo"
TextNode <#text>
BlockContainer <(anonymous)> at (11,11) content-size 0x0 children: inline
TextNode <#text>