RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 22:57:44 +00:00
Code Issues Activity Actions

LibJS: Shrink Identifier's environment coordinate cache

Browse source 
This patch does two things:

- We now use u32 instead of size_t for the hops and index fields
  in EnvironmentCoordinate. This means we're limited to an environment
  nesting level and variable count of 4Gs respectively.

- Instead of wrapping it in an Optional, EnvironmentCoordinate now has
  a custom valid/invalid state using a magic marker value.

These two changes reduce the size of Identifier by 16 bytes. :^)
This commit is contained in:
Andreas Kling 2022-11-21 18:01:22 +01:00
parent 76f438eb3e
commit 0f1f925532
4 changed files with 16 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibJS/AST.cpp
View file

@ -1387,13 +1387,13 @@ ThrowCompletionOr<Reference> Expression::to_reference(Interpreter&) const
ThrowCompletionOr<Reference> Identifier::to_reference(Interpreter& interpreter) const
{
if (m_cached_environment_coordinate.has_value()) {
if (m_cached_environment_coordinate.is_valid()) {
Environment* environment = nullptr;
if (m_cached_environment_coordinate->index == EnvironmentCoordinate::global_marker) {
if (m_cached_environment_coordinate.index == EnvironmentCoordinate::global_marker) {
environment = &interpreter.vm().current_realm()->global_environment();
} else {
environment = interpreter.vm().running_execution_context().lexical_environment;
for (size_t i = 0; i < m_cached_environment_coordinate->hops; ++i)
for (size_t i = 0; i < m_cached_environment_coordinate.hops; ++i)
environment = environment->outer_environment();
VERIFY(environment);
VERIFY(environment->is_declarative_environment());
@ -1406,7 +1406,7 @@ ThrowCompletionOr<Reference> Identifier::to_reference(Interpreter& interpreter)
auto reference = TRY(interpreter.vm().resolve_binding(string()));
if (reference.environment_coordinate().has_value())
m_cached_environment_coordinate = reference.environment_coordinate();
m_cached_environment_coordinate = reference.environment_coordinate().value();
return reference;
}