RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:57:34 +00:00
Code Issues Activity Actions

Browser: Show a "source location hint" for syntax errors :^)

Browse source
This commit is contained in:
Linus Groh 2020-05-26 13:13:12 +01:00 • committed by Andreas Kling
parent 015d65bc6f
commit 0f2b3cd280
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Applications/Browser/ConsoleWidget.cpp
View file

@ -79,15 +79,18 @@ ConsoleWidget::ConsoleWidget()
auto parser = JS::Parser(JS::Lexer(js_source)); auto parser = JS::Parser(JS::Lexer(js_source));
auto program = parser.parse_program(); auto program = parser.parse_program();
StringBuilder output_html;
if (parser.has_errors()) { if (parser.has_errors()) {
auto error = parser.errors()[0]; auto error = parser.errors()[0];
auto hint = error.source_location_hint(js_source);
if (!hint.is_empty())
output_html.append(String::format("<pre>%s</pre>", hint.characters()));
m_interpreter->throw_exception<JS::SyntaxError>(error.to_string()); m_interpreter->throw_exception<JS::SyntaxError>(error.to_string());
} else { } else {
m_interpreter->run(*program); m_interpreter->run(*program);
} }
if (m_interpreter->exception()) { if (m_interpreter->exception()) {
StringBuilder output_html;
output_html.append("Uncaught exception: "); output_html.append("Uncaught exception: ");
output_html.append(JS::MarkupGenerator::html_from_value(m_interpreter->exception()->value())); output_html.append(JS::MarkupGenerator::html_from_value(m_interpreter->exception()->value()));
print_html(output_html.string_view()); print_html(output_html.string_view());