RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 08:58:11 +00:00
Code Issues Activity Actions

Kernel: Separate out the symbol offsets in profile output

Browse source 
Instead of saying "main +39" and "main +57" etc, we now have a separate
field in /proc/profile for the offset-into-the-symbol.
This commit is contained in:
Andreas Kling 2019-12-12 21:59:47 +01:00
parent 078ee798f7
commit 0f393148da
5 changed files with 19 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Kernel/Profiling.cpp
View file

@ -57,19 +57,24 @@ static void symbolicate(Sample& stack)
for (auto& symbol : recognized_symbols) {
if (!symbol.address)
break;
auto& symbol_string_slot = stack.symbolicated_frames[i++];
auto& symbol_string_slot = stack.symbolicated_frames[i];
auto& offset_slot = stack.offsets[i];
++i;
if (!symbol.ksym) {
if (!Scheduler::is_active() && process.elf_loader() && process.elf_loader()->has_symbols())
symbol_string_slot = String::format("%s", process.elf_loader()->symbolicate(symbol.address).characters());
symbol_string_slot = process.elf_loader()->symbolicate(symbol.address, &offset_slot);
else
symbol_string_slot = String::empty();
continue;
}
unsigned offset = symbol.address - symbol.ksym->address;
if (symbol.ksym->address == ksym_highest_address && offset > 4096)
u32 offset = symbol.address - symbol.ksym->address;
if (symbol.ksym->address == ksym_highest_address && offset > 4096) {
symbol_string_slot = String::empty();
else
symbol_string_slot = String::format("%s +%u", demangle(symbol.ksym->name).characters(), offset);
offset_slot = 0;
} else {
symbol_string_slot = demangle(symbol.ksym->name);
offset_slot = offset;
}
}
}