RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:37:35 +00:00
Code Issues Activity Actions

Kernel: Convert remaining users of copy_string_from_user()

Browse source 
This patch replaces the remaining users of this API with the new
try_copy_kstring_from_user() instead. Note that we still convert to a
String for continued processing, and I've added FIXME about continuing
work on using KString all the way.
This commit is contained in:
Andreas Kling 2021-08-14 23:00:06 +02:00
parent 9509433e25
commit 0f6f863382
4 changed files with 21 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Kernel/Syscalls/hostname.cpp
View file

@ -32,10 +32,11 @@ KResultOr<FlatPtr> Process::sys$sethostname(Userspace<const char*> buffer, size_
if (length > 64)
return ENAMETOOLONG;
return hostname().with_exclusive([&](auto& name) -> KResultOr<FlatPtr> {
auto copied_hostname = copy_string_from_user(buffer, length);
if (copied_hostname.is_null())
return EFAULT;
name = move(copied_hostname);
auto name_or_error = try_copy_kstring_from_user(buffer, length);
if (name_or_error.is_error())
return name_or_error.error();
// FIXME: Use KString instead of String here.
name = name_or_error.value()->view();
return 0;
});
}