RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 19:38:12 +00:00
Code Issues Activity Actions

Kernel: Convert remaining users of copy_string_from_user()

Browse source 
This patch replaces the remaining users of this API with the new
try_copy_kstring_from_user() instead. Note that we still convert to a
String for continued processing, and I've added FIXME about continuing
work on using KString all the way.
This commit is contained in:
Andreas Kling 2021-08-14 23:00:06 +02:00
parent 9509433e25
commit 0f6f863382
4 changed files with 21 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Kernel/Syscalls/process.cpp
View file

@ -41,13 +41,14 @@ KResultOr<FlatPtr> Process::sys$set_process_name(Userspace<const char*> user_nam
REQUIRE_PROMISE(proc);
if (user_name_length > 256)
return ENAMETOOLONG;
auto name = copy_string_from_user(user_name, user_name_length);
if (name.is_null())
return EFAULT;
auto name_or_error = try_copy_kstring_from_user(user_name, user_name_length);
if (name_or_error.is_error())
return name_or_error.error();
// Empty and whitespace-only names only exist to confuse users.
if (name.is_whitespace())
if (name_or_error.value()->view().is_whitespace())
return EINVAL;
m_name = move(name);
// FIXME: There's a String copy here. Process::m_name should be a KString.
m_name = name_or_error.value()->view();
return 0;
}