From 0f9ca51c7625d66c2728f8837af1eafd614bae0a Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sun, 5 Dec 2021 10:49:21 +0100 Subject: [PATCH] Kernel: Remove unused Inode::preopen_fd() --- Kernel/FileSystem/Inode.h | 2 -- Kernel/FileSystem/VirtualFileSystem.cpp | 6 +----- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/Kernel/FileSystem/Inode.h b/Kernel/FileSystem/Inode.h index 85a8cae66c..acc58eee7a 100644 --- a/Kernel/FileSystem/Inode.h +++ b/Kernel/FileSystem/Inode.h @@ -71,8 +71,6 @@ public: bool bind_socket(LocalSocket&); bool unbind_socket(); - virtual OpenFileDescription* preopen_fd() { return nullptr; }; - bool is_metadata_dirty() const { return m_metadata_dirty; } virtual ErrorOr set_atime(time_t); diff --git a/Kernel/FileSystem/VirtualFileSystem.cpp b/Kernel/FileSystem/VirtualFileSystem.cpp index b23fd30cd7..1c104efe4c 100644 --- a/Kernel/FileSystem/VirtualFileSystem.cpp +++ b/Kernel/FileSystem/VirtualFileSystem.cpp @@ -248,9 +248,6 @@ ErrorOr> VirtualFileSystem::open(StringView p return EACCES; } - if (auto preopen_fd = inode.preopen_fd()) - return *preopen_fd; - if (metadata.is_fifo()) { auto fifo = TRY(inode.fifo()); if (options & O_WRONLY) { @@ -282,8 +279,7 @@ ErrorOr> VirtualFileSystem::open(StringView p return description; } - // Check for read-only FS. Do this after handling preopen FD and devices, - // but before modifying the inode in any way. + // Check for read-only FS. Do this after handling devices, but before modifying the inode in any way. if ((options & O_WRONLY) && custody.is_readonly()) return EROFS;