RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 13:37:43 +00:00
Code Issues Activity Actions

LibJS: Key shape transitions on both property name and attributes

Browse source 
This allows us to cache forward transitions that reconfigure existing
properties as well, leading to better shape reuse.
This commit is contained in:
Andreas Kling 2020-04-10 16:33:44 +02:00
parent 8cbb8491cb
commit 0fea525373
2 changed files with 30 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Libraries/LibJS/Runtime/Shape.cpp
View file

@ -31,21 +31,21 @@ namespace JS {
Shape* Shape::create_put_transition(const FlyString& property_name, u8 attributes) Shape* Shape::create_put_transition(const FlyString& property_name, u8 attributes)
{ {
auto* new_shape = m_forward_transitions.get(property_name).value_or(nullptr); TransitionKey key { property_name, attributes };
if (new_shape && new_shape->m_attributes == attributes) if (auto* existing_shape = m_forward_transitions.get(key).value_or(nullptr))
return new_shape; return existing_shape;
new_shape = heap().allocate<Shape>(this, property_name, attributes, TransitionType::Put); auto* new_shape = heap().allocate<Shape>(this, property_name, attributes, TransitionType::Put);
m_forward_transitions.set(property_name, new_shape); m_forward_transitions.set(key, new_shape);
return new_shape; return new_shape;
} }
Shape* Shape::create_configure_transition(const FlyString& property_name, u8 attributes) Shape* Shape::create_configure_transition(const FlyString& property_name, u8 attributes)
{ {
auto* new_shape = m_forward_transitions.get(property_name).value_or(nullptr); TransitionKey key { property_name, attributes };
if (new_shape && new_shape->m_attributes == attributes) if (auto* existing_shape = m_forward_transitions.get(key).value_or(nullptr))
return new_shape; return existing_shape;
new_shape = heap().allocate<Shape>(this, property_name, attributes, TransitionType::Configure); auto* new_shape = heap().allocate<Shape>(this, property_name, attributes, TransitionType::Configure);
m_forward_transitions.set(property_name, new_shape); m_forward_transitions.set(key, new_shape);
return new_shape; return new_shape;
} }

21
Libraries/LibJS/Runtime/Shape.h
View file

@ -48,6 +48,17 @@ struct PropertyMetadata {
u8 attributes { 0 }; u8 attributes { 0 };
}; };
struct TransitionKey {
FlyString property_name;
u8 attributes { 0 };
bool operator==(const TransitionKey& other) const
{
return property_name == other.property_name
&& attributes == other.attributes;
}
};
class Shape final : public Cell { class Shape final : public Cell {
public: public:
virtual ~Shape() override; virtual ~Shape() override;
@ -84,7 +95,7 @@ private:
mutable OwnPtr<HashMap<FlyString, PropertyMetadata>> m_property_table; mutable OwnPtr<HashMap<FlyString, PropertyMetadata>> m_property_table;
HashMap<FlyString, Shape*> m_forward_transitions; HashMap<TransitionKey, Shape*> m_forward_transitions;
Shape* m_previous { nullptr }; Shape* m_previous { nullptr };
FlyString m_property_name; FlyString m_property_name;
u8 m_attributes { 0 }; u8 m_attributes { 0 };
@ -93,3 +104,11 @@ private:
}; };
} }
template<>
struct AK::Traits<JS::TransitionKey> : public GenericTraits<JS::TransitionKey> {
static unsigned hash(const JS::TransitionKey& key)
{
return pair_int_hash(int_hash(key.attributes), key.property_name.hash());
}
};