RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 05:17:35 +00:00
Code Issues Activity Actions

AK: Assert refcount doesn't overflow

Browse source 
We don't really have a good way to prevent this kind of overflow,
but let's at least immediately panic in this case.
This commit is contained in:
Sergey Bugaev 2020-06-12 16:44:17 +03:00 • committed by Andreas Kling
parent c80e657dda
commit 0ff3c1c34d
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
AK/RefCounted.h
View file

@ -28,6 +28,7 @@
#include <AK/Assertions.h> #include <AK/Assertions.h>
#include <AK/Atomic.h> #include <AK/Atomic.h>
#include <AK/Checked.h>
#include <AK/Platform.h> #include <AK/Platform.h>
#include <AK/StdLibExtras.h> #include <AK/StdLibExtras.h>
@ -65,6 +66,7 @@ public:
{ {
auto old_ref_count = m_ref_count++; auto old_ref_count = m_ref_count++;
ASSERT(old_ref_count > 0); ASSERT(old_ref_count > 0);
ASSERT(!Checked<RefCountType>::addition_would_overflow(old_ref_count, 1));
} }
ALWAYS_INLINE RefCountType ref_count() const ALWAYS_INLINE RefCountType ref_count() const