From 102ac09ad731ce272aa52fccc821fbc69b3ff217 Mon Sep 17 00:00:00 2001 From: Liav A Date: Fri, 6 May 2022 15:29:24 +0300 Subject: [PATCH] WindowServer: Stop spurious debug spam after flushing the framebuffer This became apparent when using the VirtIO graphics device, because the HardwareScreenBackend object needs to allow flushing of the framebuffer constantly, and due to incorrect if-else flow, even a non-error response from the ioctl was leading to a debug spam. --- Userland/Services/WindowServer/HardwareScreenBackend.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Userland/Services/WindowServer/HardwareScreenBackend.cpp b/Userland/Services/WindowServer/HardwareScreenBackend.cpp index 312d0e621c..c8c746eb8b 100644 --- a/Userland/Services/WindowServer/HardwareScreenBackend.cpp +++ b/Userland/Services/WindowServer/HardwareScreenBackend.cpp @@ -143,7 +143,7 @@ ErrorOr HardwareScreenBackend::flush_framebuffer_rects(int buffer_index, S int rc = fb_flush_buffers(m_framebuffer_fd, buffer_index, flush_rects.data(), (unsigned)flush_rects.size()); if (rc == -ENOTSUP) m_can_device_flush_buffers = false; - else + else if (rc != 0) return Error::from_syscall("fb_flush_buffers", rc); return {}; } @@ -153,7 +153,7 @@ ErrorOr HardwareScreenBackend::flush_framebuffer() int rc = fb_flush_head(m_framebuffer_fd); if (rc == -ENOTSUP) m_can_device_flush_entire_framebuffer = false; - else + else if (rc != 0) return Error::from_syscall("fb_flush_head", rc); return {}; }