RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:07:45 +00:00
Code Issues Activity Actions

Libraries: Use default constructors/destructors in LibLine

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-03-04 13:19:54 -07:00 • committed by Andreas Kling
parent dcdc62323d
commit 103ce2f9e9
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibLine/Style.h
View file

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2020, the SerenityOS developers. * Copyright (c) 2020-2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -96,7 +96,7 @@ public:
m_has_link = true; m_has_link = true;
} }
Hyperlink() { } Hyperlink() = default;
String to_vt_escape(bool starting) const; String to_vt_escape(bool starting) const;
@ -119,7 +119,7 @@ public:
set(style_arg); set(style_arg);
m_is_empty = false; m_is_empty = false;
} }
Style() { } Style() = default;
static Style reset_style() static Style reset_style()
{ {

6
Userland/Libraries/LibLine/SuggestionDisplay.h
View file

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2020, the SerenityOS developers. * Copyright (c) 2020-2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -18,7 +18,7 @@ class Editor;
class SuggestionDisplay { class SuggestionDisplay {
public: public:
virtual ~SuggestionDisplay() { } virtual ~SuggestionDisplay() = default;
virtual void display(SuggestionManager const&) = 0; virtual void display(SuggestionManager const&) = 0;
virtual bool cleanup() = 0; virtual bool cleanup() = 0;
virtual void finish() = 0; virtual void finish() = 0;
@ -62,7 +62,7 @@ public:
, m_num_columns(columns) , m_num_columns(columns)
{ {
} }
virtual ~XtermSuggestionDisplay() override { } virtual ~XtermSuggestionDisplay() override = default;
virtual void display(SuggestionManager const&) override; virtual void display(SuggestionManager const&) override;
virtual bool cleanup() override; virtual bool cleanup() override;
virtual void finish() override virtual void finish() override