RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 14:32:46 +00:00
Code Issues Activity Actions

LibUnicode: Fix Hangul syllable composition for specific cases

Browse source 
This fixes `combine_hangul_code_points` which would try to combine
a LVT syllable with a trailing consonant, resulting in a wrong
character.

Also added a test for this specific case.
This commit is contained in:
matcool 2022-10-06 14:09:51 -03:00 • committed by Tim Flynn
parent ce0e4b71a3
commit 104b51b912
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibUnicode/Normalize.cpp
View file

@ -111,7 +111,8 @@ static u32 combine_hangul_code_points(u32 a, u32 b)
auto const leading_vowel_index = leading_index * HANGUL_BLOCK_COUNT + vowel_index * HANGUL_TRAILING_COUNT;
return HANGUL_SYLLABLE_BASE + leading_vowel_index;
}
if (is_hangul_code_point(a) && is_hangul_trailing(b)) {
// LV characters are the first in each "T block", so use this check to avoid combining LVT with T.
if (is_hangul_code_point(a) && (a - HANGUL_SYLLABLE_BASE) % HANGUL_TRAILING_COUNT == 0 && is_hangul_trailing(b)) {
return a + b - HANGUL_TRAILING_BASE;
}
return 0;