mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 09:37:34 +00:00
LibWeb: Obey CSS aspect-ratio property during layout
Calculate a "preferred aspect ratio" based on the value of `aspect-ratio` and the presence of a natural aspect ratio, and use that in layout. This is by no means complete or perfect, but we do now apply the given aspect-ratio to things. The spec is a bit vague, just saying to calculate sizes for aspect-ratio'ed boxes the same as you would for replaced elements. My naive solution here is to find everywhere we were checking for a ReplacedBox, and then also accept a regular Box with a preferred aspect ratio. This gets us pretty far. :^) https://www.w3.org/TR/css-sizing-4/#aspect-ratio-minimum is not at all implemented.
This commit is contained in:
parent
84e7216603
commit
1051624084
14 changed files with 131 additions and 55 deletions
|
@ -50,8 +50,8 @@ public:
|
|||
|
||||
static bool creates_block_formatting_context(Box const&);
|
||||
|
||||
CSSPixels compute_width_for_replaced_element(ReplacedBox const&, AvailableSpace const&) const;
|
||||
CSSPixels compute_height_for_replaced_element(ReplacedBox const&, AvailableSpace const&) const;
|
||||
CSSPixels compute_width_for_replaced_element(Box const&, AvailableSpace const&) const;
|
||||
CSSPixels compute_height_for_replaced_element(Box const&, AvailableSpace const&) const;
|
||||
|
||||
OwnPtr<FormattingContext> create_independent_formatting_context_if_needed(LayoutState&, Box const& child_box);
|
||||
|
||||
|
@ -112,18 +112,18 @@ protected:
|
|||
CSSPixels preferred_minimum_width { 0 };
|
||||
};
|
||||
|
||||
CSSPixels tentative_width_for_replaced_element(ReplacedBox const&, CSS::Size const& computed_width, AvailableSpace const&) const;
|
||||
CSSPixels tentative_height_for_replaced_element(ReplacedBox const&, CSS::Size const& computed_height, AvailableSpace const&) const;
|
||||
CSSPixels tentative_width_for_replaced_element(Box const&, CSS::Size const& computed_width, AvailableSpace const&) const;
|
||||
CSSPixels tentative_height_for_replaced_element(Box const&, CSS::Size const& computed_height, AvailableSpace const&) const;
|
||||
CSSPixels compute_auto_height_for_block_formatting_context_root(Box const&) const;
|
||||
|
||||
[[nodiscard]] CSSPixelSize solve_replaced_size_constraint(CSSPixels input_width, CSSPixels input_height, ReplacedBox const&) const;
|
||||
[[nodiscard]] CSSPixelSize solve_replaced_size_constraint(CSSPixels input_width, CSSPixels input_height, Box const&) const;
|
||||
|
||||
ShrinkToFitResult calculate_shrink_to_fit_widths(Box const&);
|
||||
|
||||
void layout_absolutely_positioned_element(Box const&, AvailableSpace const&);
|
||||
void compute_width_for_absolutely_positioned_element(Box const&, AvailableSpace const&);
|
||||
void compute_width_for_absolutely_positioned_non_replaced_element(Box const&, AvailableSpace const&);
|
||||
void compute_width_for_absolutely_positioned_replaced_element(ReplacedBox const&, AvailableSpace const&);
|
||||
void compute_width_for_absolutely_positioned_replaced_element(Box const&, AvailableSpace const&);
|
||||
|
||||
enum class BeforeOrAfterInsideLayout {
|
||||
Before,
|
||||
|
@ -131,7 +131,7 @@ protected:
|
|||
};
|
||||
void compute_height_for_absolutely_positioned_element(Box const&, AvailableSpace const&, BeforeOrAfterInsideLayout);
|
||||
void compute_height_for_absolutely_positioned_non_replaced_element(Box const&, AvailableSpace const&, BeforeOrAfterInsideLayout);
|
||||
void compute_height_for_absolutely_positioned_replaced_element(ReplacedBox const&, AvailableSpace const&, BeforeOrAfterInsideLayout);
|
||||
void compute_height_for_absolutely_positioned_replaced_element(Box const&, AvailableSpace const&, BeforeOrAfterInsideLayout);
|
||||
|
||||
Type m_type {};
|
||||
|
||||
|
@ -141,4 +141,6 @@ protected:
|
|||
LayoutState& m_state;
|
||||
};
|
||||
|
||||
bool box_is_sized_as_replaced_element(Box const&);
|
||||
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue