From 10581cfaebe20e9c54c27f34c7ee22988d070a39 Mon Sep 17 00:00:00 2001
From: Luke Wilde <lukew@serenityos.org>
Date: Sat, 19 Feb 2022 20:01:20 +0000
Subject: [PATCH] LibWeb: Use DOMParserSupportedType enum for
 DOMParser.parseFromString

Previously it would accept any DOMString, as we didn't support enums at
the time. Now it will only accept what's specified in the
DOMParserSupportedType enum.

This also adds spec comments to DOMParser::parse_from_string.
---
 Userland/Libraries/LibWeb/Forward.h          |  1 +
 Userland/Libraries/LibWeb/HTML/DOMParser.cpp | 31 ++++++++++++++++----
 Userland/Libraries/LibWeb/HTML/DOMParser.h   |  2 +-
 Userland/Libraries/LibWeb/HTML/DOMParser.idl | 11 +++++--
 4 files changed, 36 insertions(+), 9 deletions(-)

diff --git a/Userland/Libraries/LibWeb/Forward.h b/Userland/Libraries/LibWeb/Forward.h
index ec1567986d..296a05939c 100644
--- a/Userland/Libraries/LibWeb/Forward.h
+++ b/Userland/Libraries/LibWeb/Forward.h
@@ -504,5 +504,6 @@ class XMLHttpRequestConstructor;
 class XMLHttpRequestEventTargetWrapper;
 class XMLHttpRequestPrototype;
 class XMLHttpRequestWrapper;
+enum class DOMParserSupportedType;
 enum class XMLHttpRequestResponseType;
 }
diff --git a/Userland/Libraries/LibWeb/HTML/DOMParser.cpp b/Userland/Libraries/LibWeb/HTML/DOMParser.cpp
index 27c83e391a..de8ca9c07b 100644
--- a/Userland/Libraries/LibWeb/HTML/DOMParser.cpp
+++ b/Userland/Libraries/LibWeb/HTML/DOMParser.cpp
@@ -4,6 +4,7 @@
  * SPDX-License-Identifier: BSD-2-Clause
  */
 
+#include <LibWeb/Bindings/DOMParserWrapper.h>
 #include <LibWeb/HTML/DOMParser.h>
 #include <LibWeb/HTML/Parser/HTMLParser.h>
 
@@ -18,23 +19,41 @@ DOMParser::~DOMParser()
 }
 
 // https://html.spec.whatwg.org/multipage/dynamic-markup-insertion.html#dom-domparser-parsefromstring
-NonnullRefPtr<DOM::Document> DOMParser::parse_from_string(String const& string, String const& type)
+NonnullRefPtr<DOM::Document> DOMParser::parse_from_string(String const& string, Bindings::DOMParserSupportedType type)
 {
+    // 1. Let document be a new Document, whose content type is type and url is this's relevant global object's associated Document's URL.
     // FIXME: Pass in this's relevant global object's associated Document's URL.
     auto document = DOM::Document::create();
-    document->set_content_type(type);
+    document->set_content_type(Bindings::idl_enum_to_string(type));
 
-    // NOTE: This isn't a case insensitive match since the DOMParserSupportedType enum enforces an all lowercase type.
-    if (type == "text/html") {
-        // FIXME: Set document's type to "html".
+    // 2. Switch on type:
+    if (type == Bindings::DOMParserSupportedType::Text_Html) {
+        // -> "text/html"
+        // FIXME: 1. Set document's type to "html".
+
+        // 2. Create an HTML parser parser, associated with document.
+        // 3. Place string into the input stream for parser. The encoding confidence is irrelevant.
+        // FIXME: We don't have the concept of encoding confidence yet.
         HTMLParser parser(document, string, "UTF-8");
+
+        // 4. Start parser and let it run until it has consumed all the characters just inserted into the input stream.
         // FIXME: This is to match the default URL. Instead, pass in this's relevant global object's associated Document's URL.
         parser.run("about:blank");
     } else {
-        dbgln("DOMParser::parse_from_string: Unimplemented parser for type: {}", type);
+        // -> Otherwise
+        // FIXME: 1. Create an XML parser parse, associated with document, and with XML scripting support disabled.
+        //        2. Parse string using parser.
+        //        3. If the previous step resulted in an XML well-formedness or XML namespace well-formedness error, then:
+        //           1. Assert: document has no child nodes.
+        //           2. Let root be the result of creating an element given document, "parsererror", and "http://www.mozilla.org/newlayout/xml/parsererror.xml".
+        //           3. Optionally, add attributes or children to root to describe the nature of the parsing error.
+        //           4. Append root to document.
+
+        dbgln("DOMParser::parse_from_string: Unimplemented parser for type: {}", Bindings::idl_enum_to_string(type));
         TODO();
     }
 
+    // 3. Return document.
     return document;
 }
 
diff --git a/Userland/Libraries/LibWeb/HTML/DOMParser.h b/Userland/Libraries/LibWeb/HTML/DOMParser.h
index 9746eb21c2..4df6ba2d5b 100644
--- a/Userland/Libraries/LibWeb/HTML/DOMParser.h
+++ b/Userland/Libraries/LibWeb/HTML/DOMParser.h
@@ -30,7 +30,7 @@ public:
 
     virtual ~DOMParser() override;
 
-    NonnullRefPtr<DOM::Document> parse_from_string(String const&, String const&);
+    NonnullRefPtr<DOM::Document> parse_from_string(String const&, Bindings::DOMParserSupportedType type);
 
 private:
     DOMParser();
diff --git a/Userland/Libraries/LibWeb/HTML/DOMParser.idl b/Userland/Libraries/LibWeb/HTML/DOMParser.idl
index b30d46bc1e..71e6a742e7 100644
--- a/Userland/Libraries/LibWeb/HTML/DOMParser.idl
+++ b/Userland/Libraries/LibWeb/HTML/DOMParser.idl
@@ -1,8 +1,15 @@
 #import <DOM/Document.idl>
 
+enum DOMParserSupportedType {
+    "text/html",
+    "text/xml",
+    "application/xml",
+    "application/xhtml+xml",
+    "image/svg+xml"
+};
+
 interface DOMParser {
     constructor();
 
-    // FIXME: "type" should use the DOMParserSupportedType enum.
-    Document parseFromString(DOMString string, DOMString type);
+    Document parseFromString(DOMString string, DOMParserSupportedType type);
 };