From 106ad6ba0945612ddbf19774da0fee1f78ee542e Mon Sep 17 00:00:00 2001
From: Max Wipfli <mail@maxwipfli.ch>
Date: Thu, 3 Jun 2021 23:55:16 +0200
Subject: [PATCH] LibJS: Fix off-by-one error in SyntaxHighlighter

This changes the JS syntax highlighter to conform to the now-fixed
rendering of syntax highlighting spans in GUI::TextEditor.
---
 Userland/Libraries/LibJS/SyntaxHighlighter.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Userland/Libraries/LibJS/SyntaxHighlighter.cpp b/Userland/Libraries/LibJS/SyntaxHighlighter.cpp
index 58268b4a14..d5b5670827 100644
--- a/Userland/Libraries/LibJS/SyntaxHighlighter.cpp
+++ b/Userland/Libraries/LibJS/SyntaxHighlighter.cpp
@@ -72,7 +72,7 @@ void SyntaxHighlighter::rehighlight(const Palette& palette)
             return;
 
         start = position;
-        for (size_t i = 0; i < str.length() - 1; ++i)
+        for (size_t i = 0; i < str.length(); ++i)
             advance_position(str[i]);
 
         GUI::TextDocumentSpan span;
@@ -85,7 +85,6 @@ void SyntaxHighlighter::rehighlight(const Palette& palette)
         span.is_skippable = is_trivia;
         span.data = reinterpret_cast<void*>(static_cast<size_t>(type));
         spans.append(span);
-        advance_position(str[str.length() - 1]);
 
         dbgln_if(SYNTAX_HIGHLIGHTING_DEBUG, "{}{} @ '{}' {}:{} - {}:{}",
             token.name(),