RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 21:07:35 +00:00
Code Issues Activity Actions

LibJS+LibWeb: Make JS::Script and Web::HTML::ClassicScript use Realms

Browse source 
The spec wants Script Records to have a Realm, not a GlobalObject.
This commit is contained in:
Linus Groh 2021-09-12 12:02:20 +01:00 • committed by Andreas Kling
parent 673fc02ac5
commit 106f295916
5 changed files with 17 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibJS/Script.h
View file

@ -10,7 +10,7 @@
#include <AK/RefCounted.h>
#include <LibJS/AST.h>
#include <LibJS/Heap/Handle.h>
#include <LibJS/Runtime/GlobalObject.h>
#include <LibJS/Runtime/Realm.h>
namespace JS {
@ -18,16 +18,16 @@ namespace JS {
class Script : public RefCounted<Script> {
public:
~Script();
static NonnullRefPtr<Script> parse(StringView source_text, GlobalObject&, StringView filename = {});
static NonnullRefPtr<Script> parse(StringView source_text, Realm&, StringView filename = {});
GlobalObject& global_object() { return *m_global_object.cell(); }
Realm& realm() { return *m_realm.cell(); }
Program const& parse_node() const { return *m_parse_node; }
private:
Script(GlobalObject&, NonnullRefPtr<Program>);
Script(Realm&, NonnullRefPtr<Program>);
Handle<GlobalObject> m_global_object;
NonnullRefPtr<Program> m_parse_node;
Handle<Realm> m_realm; // [[Realm]]
NonnullRefPtr<Program> m_parse_node; // [[ECMAScriptCode]]
};
}