RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-22 17:15:08 +00:00
Code Issues Activity Actions

LibJS: Add function call spreading

Browse source 
Adds support for the following syntax:

    myFunction(...x, ...[1, 2, 3], ...o.foo, ...'abcd')
This commit is contained in:
Matthew Olsson 2020-05-05 22:36:24 -07:00 • committed by Andreas Kling
parent 8fe821fae2
commit 107ca2e4ba
4 changed files with 72 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Libraries/LibJS/Parser.cpp
View file

@ -777,10 +777,15 @@ NonnullRefPtr<CallExpression> Parser::parse_call_expression(NonnullRefPtr<Expres
{
consume(TokenType::ParenOpen);
NonnullRefPtrVector<Expression> arguments;
Vector<CallExpression::Argument> arguments;
while (match_expression()) {
arguments.append(parse_expression(0));
while (match_expression() || match(TokenType::TripleDot)) {
if (match(TokenType::TripleDot)) {
consume();
arguments.append({ parse_expression(0), true });
} else {
arguments.append({ parse_expression(0), false });
}
if (!match(TokenType::Comma))
break;
consume();
@ -798,12 +803,17 @@ NonnullRefPtr<NewExpression> Parser::parse_new_expression()
// FIXME: Support full expressions as the callee as well.
auto callee = create_ast_node<Identifier>(consume(TokenType::Identifier).value());
NonnullRefPtrVector<Expression> arguments;
Vector<CallExpression::Argument> arguments;
if (match(TokenType::ParenOpen)) {
consume(TokenType::ParenOpen);
while (match_expression()) {
arguments.append(parse_expression(0));
while (match_expression() || match(TokenType::TripleDot)) {
if (match(TokenType::TripleDot)) {
consume();
arguments.append({ parse_expression(0), true });
} else {
arguments.append({ parse_expression(0), false });
}
if (!match(TokenType::Comma))
break;
consume();