RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 02:17:35 +00:00
Code Issues Activity Actions

LibJS: Make GlobalEnvironmentRecord forward to the right function

Browse source 
This was accidentally deleting a property from the object record object
itself, rather than from the object record.

It's quite confusing that Environment Records are objects, but moving
away from that will require some large changes.
This commit is contained in:
Andreas Kling 2021-06-22 22:18:23 +02:00
parent f7e2994f35
commit 1082e99e08
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/GlobalEnvironmentRecord.cpp
View file

@ -42,7 +42,7 @@ void GlobalEnvironmentRecord::put_into_environment_record(FlyString const& name,
bool GlobalEnvironmentRecord::delete_from_environment_record(FlyString const& name)
{
// FIXME: This should be a "composite" of the object record and the declarative record.
return object_record().delete_property(name);
return object_record().delete_from_environment_record(name);
}
Value GlobalEnvironmentRecord::get_this_binding(GlobalObject&) const