RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:37:35 +00:00
Code Issues Activity Actions

LibX86: Only pass ProcessorMode to Instruction constructor

Browse source 
We previously passed both OperandSize and AddressSize to the
constructor.

Both values were only ever 32-bit at construction.
We used AddressSize::Size64 to signify Long mode which was needlessly
complicated.
This commit is contained in:
Itamar 2022-12-10 20:00:09 +02:00 • committed by Andreas Kling
parent 9a136e354d
commit 108a8e4c88
3 changed files with 14 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/DevTools/UserspaceEmulator/Emulator.cpp
View file

@ -234,7 +234,7 @@ int Emulator::exec()
while (!m_shutdown) { while (!m_shutdown) {
if (m_steps_til_pause) [[likely]] { if (m_steps_til_pause) [[likely]] {
m_cpu->save_base_eip(); m_cpu->save_base_eip();
auto insn = X86::Instruction::from_stream(*m_cpu, X86::OperandSize::Size32, X86::AddressSize::Size32); auto insn = X86::Instruction::from_stream(*m_cpu, X86::ProcessorMode::Protected);
// Exec cycle // Exec cycle
if constexpr (trace) { if constexpr (trace) {
outln("{:p} \033[33;1m{}\033[0m", m_cpu->base_eip(), insn.to_deprecated_string(m_cpu->base_eip(), symbol_provider)); outln("{:p} \033[33;1m{}\033[0m", m_cpu->base_eip(), insn.to_deprecated_string(m_cpu->base_eip(), symbol_provider));
@ -301,7 +301,7 @@ void Emulator::handle_repl()
// FIXME: Function names (base, call, jump) // FIXME: Function names (base, call, jump)
auto saved_eip = m_cpu->eip(); auto saved_eip = m_cpu->eip();
m_cpu->save_base_eip(); m_cpu->save_base_eip();
auto insn = X86::Instruction::from_stream(*m_cpu, X86::OperandSize::Size32, X86::AddressSize::Size32); auto insn = X86::Instruction::from_stream(*m_cpu, X86::ProcessorMode::Protected);
// FIXME: This does not respect inlining // FIXME: This does not respect inlining
// another way of getting the current function is at need // another way of getting the current function is at need
if (auto symbol = symbol_at(m_cpu->base_eip()); symbol.has_value()) { if (auto symbol = symbol_at(m_cpu->base_eip()); symbol.has_value()) {
@ -311,7 +311,7 @@ void Emulator::handle_repl()
outln("==> {}", create_instruction_line(m_cpu->base_eip(), insn)); outln("==> {}", create_instruction_line(m_cpu->base_eip(), insn));
for (int i = 0; i < 7; ++i) { for (int i = 0; i < 7; ++i) {
m_cpu->save_base_eip(); m_cpu->save_base_eip();
insn = X86::Instruction::from_stream(*m_cpu, X86::OperandSize::Size32, X86::AddressSize::Size32); insn = X86::Instruction::from_stream(*m_cpu, X86::ProcessorMode::Protected);
outln(" {}", create_instruction_line(m_cpu->base_eip(), insn)); outln(" {}", create_instruction_line(m_cpu->base_eip(), insn));
} }
// We don't want to increase EIP here, we just want the instructions // We don't want to increase EIP here, we just want the instructions

4
Userland/Libraries/LibX86/Disassembler.h
View file

@ -23,10 +23,10 @@ public:
if (!m_stream.can_read()) if (!m_stream.can_read())
return {}; return {};
#if ARCH(I386) #if ARCH(I386)
return Instruction::from_stream(m_stream, OperandSize::Size32, AddressSize::Size32); return Instruction::from_stream(m_stream, ProcessorMode::Protected);
#else #else
# if ARCH(X86_64) # if ARCH(X86_64)
return Instruction::from_stream(m_stream, OperandSize::Size32, AddressSize::Size64); return Instruction::from_stream(m_stream, ProcessorMode::Long);
# else # else
dbgln("Unsupported platform"); dbgln("Unsupported platform");
return {}; return {};

23
Userland/Libraries/LibX86/Instruction.h
View file

@ -618,7 +618,7 @@ private:
class Instruction { class Instruction {
public: public:
template<typename InstructionStreamType> template<typename InstructionStreamType>
static Instruction from_stream(InstructionStreamType&, OperandSize, AddressSize); static Instruction from_stream(InstructionStreamType&, ProcessorMode);
~Instruction() = default; ~Instruction() = default;
ALWAYS_INLINE MemoryOrRegisterReference& modrm() const { return m_modrm; } ALWAYS_INLINE MemoryOrRegisterReference& modrm() const { return m_modrm; }
@ -699,7 +699,7 @@ public:
private: private:
template<typename InstructionStreamType> template<typename InstructionStreamType>
Instruction(InstructionStreamType&, OperandSize, AddressSize); Instruction(InstructionStreamType&, ProcessorMode);
void to_deprecated_string_internal(StringBuilder&, u32 origin, SymbolProvider const*, bool x32) const; void to_deprecated_string_internal(StringBuilder&, u32 origin, SymbolProvider const*, bool x32) const;
@ -961,9 +961,9 @@ ALWAYS_INLINE typename CPU::ValueWithShadowType256 MemoryOrRegisterReference::re
} }
template<typename InstructionStreamType> template<typename InstructionStreamType>
ALWAYS_INLINE Instruction Instruction::from_stream(InstructionStreamType& stream, OperandSize operand_size, AddressSize address_size) ALWAYS_INLINE Instruction Instruction::from_stream(InstructionStreamType& stream, ProcessorMode mode)
{ {
return Instruction(stream, operand_size, address_size); return Instruction(stream, mode);
} }
ALWAYS_INLINE unsigned Instruction::length() const ALWAYS_INLINE unsigned Instruction::length() const
@ -1002,19 +1002,14 @@ ALWAYS_INLINE Optional<SegmentRegister> to_segment_prefix(u8 op)
} }
template<typename InstructionStreamType> template<typename InstructionStreamType>
ALWAYS_INLINE Instruction::Instruction(InstructionStreamType& stream, OperandSize operand_size, AddressSize address_size) ALWAYS_INLINE Instruction::Instruction(InstructionStreamType& stream, ProcessorMode mode)
: m_operand_size(operand_size) : m_mode(mode)
, m_address_size(address_size)
{ {
VERIFY(operand_size != OperandSize::Size64); m_operand_size = OperandSize::Size32;
// Use address_size as the hint to switch into long mode.
// m_address_size refers to the default size of displacements/immediates, which is 32 even in long mode (2.2.1.3 Displacement, 2.2.1.5 Immediates), // m_address_size refers to the default size of displacements/immediates, which is 32 even in long mode (2.2.1.3 Displacement, 2.2.1.5 Immediates),
// with the exception of moffset (see below). // with the exception of moffset (see below).
if (address_size == AddressSize::Size64) { m_address_size = AddressSize::Size32;
m_operand_size = OperandSize::Size32;
m_address_size = AddressSize::Size32;
m_mode = ProcessorMode::Long;
}
u8 prefix_bytes = 0; u8 prefix_bytes = 0;
for (;; ++prefix_bytes) { for (;; ++prefix_bytes) {
u8 opbyte = stream.read8(); u8 opbyte = stream.read8();