diff --git a/Userland/Libraries/LibWeb/CSS/StyleValue.cpp b/Userland/Libraries/LibWeb/CSS/StyleValue.cpp index 709a239ee6..6001bb5696 100644 --- a/Userland/Libraries/LibWeb/CSS/StyleValue.cpp +++ b/Userland/Libraries/LibWeb/CSS/StyleValue.cpp @@ -278,17 +278,17 @@ String BoxShadowStyleValue::to_string() const return builder.to_string(); } -void CalculatedStyleValue::CalculationResult::add(CalculationResult const& other, Layout::Node const* layout_node, Length const& percentage_basis) +void CalculatedStyleValue::CalculationResult::add(CalculationResult const& other, Layout::Node const* layout_node, PercentageBasis const& percentage_basis) { add_or_subtract_internal(SumOperation::Add, other, layout_node, percentage_basis); } -void CalculatedStyleValue::CalculationResult::subtract(CalculationResult const& other, Layout::Node const* layout_node, Length const& percentage_basis) +void CalculatedStyleValue::CalculationResult::subtract(CalculationResult const& other, Layout::Node const* layout_node, PercentageBasis const& percentage_basis) { add_or_subtract_internal(SumOperation::Subtract, other, layout_node, percentage_basis); } -void CalculatedStyleValue::CalculationResult::add_or_subtract_internal(SumOperation op, CalculationResult const& other, Layout::Node const* layout_node, Length const& percentage_basis) +void CalculatedStyleValue::CalculationResult::add_or_subtract_internal(SumOperation op, CalculationResult const& other, Layout::Node const* layout_node, PercentageBasis const& percentage_basis) { // We know from validation when resolving the type, that "both sides have the same type, or that one side is a and the other is an ". // Though, having the same type may mean that one side is a and the other a . @@ -318,9 +318,9 @@ void CalculatedStyleValue::CalculationResult::add_or_subtract_internal(SumOperat else m_value = Length::make_px(this_px - other_px); } else { - VERIFY(!percentage_basis.is_undefined()); + VERIFY(percentage_basis.has()); - auto other_px = percentage_basis.percentage_of(other.m_value.get()).to_px(*layout_node); + auto other_px = percentage_basis.get().percentage_of(other.m_value.get()).to_px(*layout_node); if (op == SumOperation::Add) m_value = Length::make_px(this_px + other_px); else @@ -712,7 +712,7 @@ Optional CalculatedStyleValue::CalcNumberVal [](NonnullOwnPtr const& sum) { return sum->resolved_type(); }); } -CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcNumberValue::resolve(Layout::Node const* layout_node, Length const& percentage_basis) const +CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcNumberValue::resolve(Layout::Node const* layout_node, PercentageBasis const& percentage_basis) const { return value.visit( [&](Number const& number) -> CalculatedStyleValue::CalculationResult { @@ -723,7 +723,7 @@ CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcNumberValue::r }); } -CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcValue::resolve(Layout::Node const* layout_node, Length const& percentage_basis) const +CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcValue::resolve(Layout::Node const* layout_node, PercentageBasis const& percentage_basis) const { return value.visit( [&](Number const& number) -> CalculatedStyleValue::CalculationResult { @@ -740,7 +740,7 @@ CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcValue::resolve }); } -CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcSum::resolve(Layout::Node const* layout_node, Length const& percentage_basis) const +CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcSum::resolve(Layout::Node const* layout_node, PercentageBasis const& percentage_basis) const { auto value = first_calc_product->resolve(layout_node, percentage_basis); @@ -758,7 +758,7 @@ CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcSum::resolve(L return value; } -CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcNumberSum::resolve(Layout::Node const* layout_node, Length const& percentage_basis) const +CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcNumberSum::resolve(Layout::Node const* layout_node, PercentageBasis const& percentage_basis) const { auto value = first_calc_number_product->resolve(layout_node, percentage_basis); @@ -776,7 +776,7 @@ CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcNumberSum::res return value; } -CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcProduct::resolve(Layout::Node const* layout_node, Length const& percentage_basis) const +CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcProduct::resolve(Layout::Node const* layout_node, PercentageBasis const& percentage_basis) const { auto value = first_calc_value.resolve(layout_node, percentage_basis); @@ -799,7 +799,7 @@ CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcProduct::resol return value; } -CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcNumberProduct::resolve(Layout::Node const* layout_node, Length const& percentage_basis) const +CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcNumberProduct::resolve(Layout::Node const* layout_node, PercentageBasis const& percentage_basis) const { auto value = first_calc_number_value.resolve(layout_node, percentage_basis); @@ -817,7 +817,7 @@ CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcNumberProduct: return value; } -CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcProductPartWithOperator::resolve(Layout::Node const* layout_node, Length const& percentage_basis) const +CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcProductPartWithOperator::resolve(Layout::Node const* layout_node, PercentageBasis const& percentage_basis) const { return value.visit( [&](CalcValue const& calc_value) { @@ -828,17 +828,17 @@ CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcProductPartWit }); } -CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcSumPartWithOperator::resolve(Layout::Node const* layout_node, Length const& percentage_basis) const +CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcSumPartWithOperator::resolve(Layout::Node const* layout_node, PercentageBasis const& percentage_basis) const { return value->resolve(layout_node, percentage_basis); } -CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcNumberProductPartWithOperator::resolve(Layout::Node const* layout_node, Length const& percentage_basis) const +CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcNumberProductPartWithOperator::resolve(Layout::Node const* layout_node, PercentageBasis const& percentage_basis) const { return value.resolve(layout_node, percentage_basis); } -CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcNumberSumPartWithOperator::resolve(Layout::Node const* layout_node, Length const& percentage_basis) const +CalculatedStyleValue::CalculationResult CalculatedStyleValue::CalcNumberSumPartWithOperator::resolve(Layout::Node const* layout_node, PercentageBasis const& percentage_basis) const { return value->resolve(layout_node, percentage_basis); } diff --git a/Userland/Libraries/LibWeb/CSS/StyleValue.h b/Userland/Libraries/LibWeb/CSS/StyleValue.h index 363bd9802b..4782ec8d22 100644 --- a/Userland/Libraries/LibWeb/CSS/StyleValue.h +++ b/Userland/Libraries/LibWeb/CSS/StyleValue.h @@ -691,21 +691,23 @@ public: float value; }; + using PercentageBasis = Variant; + class CalculationResult { public: CalculationResult(Variant value) : m_value(move(value)) { } - void add(CalculationResult const& other, Layout::Node const*, Length const& percentage_basis); - void subtract(CalculationResult const& other, Layout::Node const*, Length const& percentage_basis); + void add(CalculationResult const& other, Layout::Node const*, PercentageBasis const& percentage_basis); + void subtract(CalculationResult const& other, Layout::Node const*, PercentageBasis const& percentage_basis); void multiply_by(CalculationResult const& other, Layout::Node const*); void divide_by(CalculationResult const& other, Layout::Node const*); Variant const& value() const { return m_value; } private: - void add_or_subtract_internal(SumOperation op, CalculationResult const& other, Layout::Node const*, Length const& percentage_basis); + void add_or_subtract_internal(SumOperation op, CalculationResult const& other, Layout::Node const*, PercentageBasis const& percentage_basis); Variant m_value; }; @@ -722,14 +724,14 @@ public: Variant> value; String to_string() const; Optional resolved_type() const; - CalculationResult resolve(Layout::Node const*, Length const& percentage_basis) const; + CalculationResult resolve(Layout::Node const*, PercentageBasis const& percentage_basis) const; }; struct CalcValue { Variant> value; String to_string() const; Optional resolved_type() const; - CalculationResult resolve(Layout::Node const*, Length const& percentage_basis) const; + CalculationResult resolve(Layout::Node const*, PercentageBasis const& percentage_basis) const; }; // This represents that: https://www.w3.org/TR/css-values-3/#calc-syntax @@ -743,7 +745,7 @@ public: String to_string() const; Optional resolved_type() const; - CalculationResult resolve(Layout::Node const*, Length const& percentage_basis) const; + CalculationResult resolve(Layout::Node const*, PercentageBasis const& percentage_basis) const; }; struct CalcNumberSum { @@ -756,7 +758,7 @@ public: String to_string() const; Optional resolved_type() const; - CalculationResult resolve(Layout::Node const*, Length const& percentage_basis) const; + CalculationResult resolve(Layout::Node const*, PercentageBasis const& percentage_basis) const; }; struct CalcProduct { @@ -765,7 +767,7 @@ public: String to_string() const; Optional resolved_type() const; - CalculationResult resolve(Layout::Node const*, Length const& percentage_basis) const; + CalculationResult resolve(Layout::Node const*, PercentageBasis const& percentage_basis) const; }; struct CalcSumPartWithOperator { @@ -778,7 +780,7 @@ public: String to_string() const; Optional resolved_type() const; - CalculationResult resolve(Layout::Node const*, Length const& percentage_basis) const; + CalculationResult resolve(Layout::Node const*, PercentageBasis const& percentage_basis) const; }; struct CalcProductPartWithOperator { @@ -787,7 +789,7 @@ public: String to_string() const; Optional resolved_type() const; - CalculationResult resolve(Layout::Node const*, Length const& percentage_basis) const; + CalculationResult resolve(Layout::Node const*, PercentageBasis const& percentage_basis) const; }; struct CalcNumberProduct { @@ -796,7 +798,7 @@ public: String to_string() const; Optional resolved_type() const; - CalculationResult resolve(Layout::Node const*, Length const& percentage_basis) const; + CalculationResult resolve(Layout::Node const*, PercentageBasis const& percentage_basis) const; }; struct CalcNumberProductPartWithOperator { @@ -805,7 +807,7 @@ public: String to_string() const; Optional resolved_type() const; - CalculationResult resolve(Layout::Node const*, Length const& percentage_basis) const; + CalculationResult resolve(Layout::Node const*, PercentageBasis const& percentage_basis) const; }; struct CalcNumberSumPartWithOperator { @@ -818,7 +820,7 @@ public: String to_string() const; Optional resolved_type() const; - CalculationResult resolve(Layout::Node const*, Length const& percentage_basis) const; + CalculationResult resolve(Layout::Node const*, PercentageBasis const& percentage_basis) const; }; static NonnullRefPtr create(NonnullOwnPtr calc_sum, ResolvedType resolved_type)