From 10aebabf0bd21c2b0599525a708c95dca502fa7a Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Mon, 8 Jun 2020 12:08:51 +0200 Subject: [PATCH] LibJS: BigInts and Symbols values are cells and the GC needs this info Make Value::is_cell() return true for BigInts and Symbols. This makes all the tests pass when running run-tests.sh -g (GC after every alloc.) --- Libraries/LibJS/Runtime/Value.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Libraries/LibJS/Runtime/Value.h b/Libraries/LibJS/Runtime/Value.h index b7a3d712eb..2d72505c18 100644 --- a/Libraries/LibJS/Runtime/Value.h +++ b/Libraries/LibJS/Runtime/Value.h @@ -69,7 +69,7 @@ public: bool is_symbol() const { return m_type == Type::Symbol; } bool is_accessor() const { return m_type == Type::Accessor; }; bool is_bigint() const { return m_type == Type::BigInt; }; - bool is_cell() const { return is_string() || is_accessor() || is_object(); } + bool is_cell() const { return is_string() || is_accessor() || is_object() || is_bigint() || is_symbol(); } bool is_array() const; bool is_function() const;