From 10d0cac73c84fc065c43326a813a16a970046ac9 Mon Sep 17 00:00:00 2001 From: Andrew Kaster Date: Sat, 6 Nov 2021 11:26:02 -0600 Subject: [PATCH] AK: Use capitalized literal suffixes for AK::abs() overloads Using `l` for long double causes a clang-tidy warning, so use all caps suffixes for all of the AK::abs() overloads for consistency. Also, avoid leaking the internal __DEFINE_GENERIC_ABS macro. --- AK/StdLibExtras.h | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/AK/StdLibExtras.h b/AK/StdLibExtras.h index e71d7497ef..9a8928d641 100644 --- a/AK/StdLibExtras.h +++ b/AK/StdLibExtras.h @@ -146,14 +146,16 @@ constexpr bool is_constant_evaluated() } __DEFINE_GENERIC_ABS(int, 0, abs); -__DEFINE_GENERIC_ABS(long, 0l, labs); -__DEFINE_GENERIC_ABS(long long, 0ll, llabs); +__DEFINE_GENERIC_ABS(long, 0L, labs); +__DEFINE_GENERIC_ABS(long long, 0LL, llabs); #ifndef KERNEL -__DEFINE_GENERIC_ABS(float, 0.0f, fabsf); +__DEFINE_GENERIC_ABS(float, 0.0F, fabsf); __DEFINE_GENERIC_ABS(double, 0.0, fabs); -__DEFINE_GENERIC_ABS(long double, 0.0l, fabsl); +__DEFINE_GENERIC_ABS(long double, 0.0L, fabsl); #endif +#undef __DEFINE_GENERIC_ABS + } using AK::array_size;