RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:57:36 +00:00
Code Issues Activity Actions

Base+Browser: Add Browser icons

Browse source 
Add some missing icons to the brower.
This commit is contained in:
electrikmilk 2022-01-03 22:20:01 -05:00 • committed by Linus Groh
parent 0d8120eeb2
commit 10e473bf26
10 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

BIN
Base/res/icons/16x16/close-tab.png
View file

Binary file not shown.
Side by side Swipe Overlay

Before

Width:  |  Height:  |  Size: 199 B

After

Width:  |  Height:  |  Size: 2.9 KiB

Before After
Before After

BIN
Base/res/icons/16x16/cookie.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 2.8 KiB

BIN
Base/res/icons/16x16/duplicate-tab.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 2.8 KiB

BIN
Base/res/icons/16x16/fullscreen.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 2.9 KiB

BIN
Base/res/icons/16x16/new-tab.png
View file

Binary file not shown.
Side by side Swipe Overlay

Before

Width:  |  Height:  |  Size: 224 B

After

Width:  |  Height:  |  Size: 2.8 KiB

Before After
Before After

BIN
Base/res/icons/16x16/tree.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 2.8 KiB

6
Userland/Applications/Browser/BrowserWindow.cpp
View file

@ -204,7 +204,7 @@ void BrowserWindow::build_menus()
m_view_source_action->set_status_tip("View source code of the current page"); m_view_source_action->set_status_tip("View source code of the current page");
m_inspect_dom_tree_action = GUI::Action::create( m_inspect_dom_tree_action = GUI::Action::create(
"Inspect &DOM Tree", { Mod_None, Key_F12 }, [this](auto&) { "Inspect &DOM Tree", { Mod_None, Key_F12 }, Gfx::Bitmap::try_load_from_file("/res/icons/16x16/tree.png").release_value_but_fixme_should_propagate_errors(), [this](auto&) {
active_tab().show_inspector_window(Tab::InspectorTarget::Document); active_tab().show_inspector_window(Tab::InspectorTarget::Document);
}, },
this); this);
@ -343,7 +343,7 @@ void BrowserWindow::build_menus()
auto& debug_menu = add_menu("&Debug"); auto& debug_menu = add_menu("&Debug");
debug_menu.add_action(GUI::Action::create( debug_menu.add_action(GUI::Action::create(
"Dump &DOM Tree", [this](auto&) { "Dump &DOM Tree", Gfx::Bitmap::try_load_from_file("/res/icons/16x16/tree.png").release_value_but_fixme_should_propagate_errors(), [this](auto&) {
active_tab().m_web_content_view->debug_request("dump-dom-tree"); active_tab().m_web_content_view->debug_request("dump-dom-tree");
}, },
this)); this));
@ -360,7 +360,7 @@ void BrowserWindow::build_menus()
debug_menu.add_action(GUI::Action::create("Dump &History", { Mod_Ctrl, Key_H }, [this](auto&) { debug_menu.add_action(GUI::Action::create("Dump &History", { Mod_Ctrl, Key_H }, [this](auto&) {
active_tab().m_history.dump(); active_tab().m_history.dump();
})); }));
debug_menu.add_action(GUI::Action::create("Dump C&ookies", [this](auto&) { debug_menu.add_action(GUI::Action::create("Dump C&ookies", Gfx::Bitmap::try_load_from_file("/res/icons/16x16/cookie.png").release_value_but_fixme_should_propagate_errors(), [this](auto&) {
auto& tab = active_tab(); auto& tab = active_tab();
if (tab.on_dump_cookies) if (tab.on_dump_cookies)
tab.on_dump_cookies(); tab.on_dump_cookies();

2
Userland/Applications/Browser/Tab.cpp
View file

@ -332,7 +332,7 @@ Tab::Tab(BrowserWindow& window)
m_tab_context_menu->add_action(GUI::CommonActions::make_close_tab_action([this](auto&) { m_tab_context_menu->add_action(GUI::CommonActions::make_close_tab_action([this](auto&) {
on_tab_close_request(*this); on_tab_close_request(*this);
})); }));
m_tab_context_menu->add_action(GUI::Action::create("&Duplicate Tab", [this](auto&) { m_tab_context_menu->add_action(GUI::Action::create("&Duplicate Tab", Gfx::Bitmap::try_load_from_file("/res/icons/16x16/duplicate-tab.png").release_value_but_fixme_should_propagate_errors(), [this](auto&) {
on_tab_open_request(url()); on_tab_open_request(url());
})); }));
m_tab_context_menu->add_action(GUI::Action::create("Close &Other Tabs", [this](auto&) { m_tab_context_menu->add_action(GUI::Action::create("Close &Other Tabs", [this](auto&) {

1
Userland/Libraries/LibGUI/CommonActions.cpp
View file

@ -100,6 +100,7 @@ NonnullRefPtr<Action> make_fullscreen_action(Function<void(Action&)> callback, C
{ {
auto action = Action::create("&Fullscreen", { Mod_None, Key_F11 }, move(callback), parent); auto action = Action::create("&Fullscreen", { Mod_None, Key_F11 }, move(callback), parent);
action->set_status_tip("Enter fullscreen mode"); action->set_status_tip("Enter fullscreen mode");
action->set_icon(Gfx::Bitmap::try_load_from_file("/res/icons/16x16/fullscreen.png").release_value_but_fixme_should_propagate_errors());
return action; return action;
} }

2
Userland/Libraries/LibWeb/Loader/FrameLoader.cpp
View file

@ -30,7 +30,7 @@ FrameLoader::FrameLoader(HTML::BrowsingContext& browsing_context)
: m_browsing_context(browsing_context) : m_browsing_context(browsing_context)
{ {
if (!s_default_favicon_bitmap) { if (!s_default_favicon_bitmap) {
s_default_favicon_bitmap = Gfx::Bitmap::try_load_from_file("/res/icons/16x16/filetype-html.png").release_value_but_fixme_should_propagate_errors(); s_default_favicon_bitmap = Gfx::Bitmap::try_load_from_file("/res/icons/16x16/app-browser.png").release_value_but_fixme_should_propagate_errors();
VERIFY(s_default_favicon_bitmap); VERIFY(s_default_favicon_bitmap);
} }
} }