mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 18:27:35 +00:00
LibCore: Keep track of file offset to avoid system call for tell()
This optimization makes the new test run 2x faster.
This commit is contained in:
parent
111fd1e5fe
commit
10edd38543
3 changed files with 33 additions and 1 deletions
|
@ -117,6 +117,7 @@ ErrorOr<Bytes> File::read_some(Bytes buffer)
|
|||
|
||||
ssize_t nread = TRY(System::read(m_fd, buffer));
|
||||
m_last_read_was_eof = nread == 0;
|
||||
m_file_offset += nread;
|
||||
return buffer.trim(nread);
|
||||
}
|
||||
|
||||
|
@ -135,7 +136,9 @@ ErrorOr<size_t> File::write_some(ReadonlyBytes buffer)
|
|||
return Error::from_errno(EBADF);
|
||||
}
|
||||
|
||||
return TRY(System::write(m_fd, buffer));
|
||||
auto nwritten = TRY(System::write(m_fd, buffer));
|
||||
m_file_offset += nwritten;
|
||||
return nwritten;
|
||||
}
|
||||
|
||||
bool File::is_eof() const { return m_last_read_was_eof; }
|
||||
|
@ -177,15 +180,22 @@ ErrorOr<size_t> File::seek(i64 offset, SeekMode mode)
|
|||
}
|
||||
|
||||
size_t seek_result = TRY(System::lseek(m_fd, offset, syscall_mode));
|
||||
m_file_offset = seek_result;
|
||||
m_last_read_was_eof = false;
|
||||
return seek_result;
|
||||
}
|
||||
|
||||
ErrorOr<size_t> File::tell() const
|
||||
{
|
||||
return m_file_offset;
|
||||
}
|
||||
|
||||
ErrorOr<void> File::truncate(size_t length)
|
||||
{
|
||||
if (length > static_cast<size_t>(NumericLimits<off_t>::max()))
|
||||
return Error::from_string_literal("Length is larger than the maximum supported length");
|
||||
|
||||
m_file_offset = min(length, m_file_offset);
|
||||
return System::ftruncate(m_fd, length);
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue