RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:17:36 +00:00
Code Issues Activity Actions

FileManager: Fix recursive copy on drag

Browse source 
When a drag operation is accepted, we don't check whether the source
nodes contain the destination directory. This could trigger an unwanted
recursive copy.
This commit is contained in:
angel 2020-04-19 16:52:46 +02:00 • committed by Andreas Kling
parent fc09767872
commit 11054fc9f9
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Applications/FileManager/main.cpp
View file

@ -684,7 +684,7 @@ int run_in_windowed_mode(RefPtr<Core::ConfigFile> config, String initial_locatio
return; return;
for (auto& url_to_copy : urls) { for (auto& url_to_copy : urls) {
if (!url_to_copy.is_valid()) if (!url_to_copy.is_valid() || url_to_copy.path() == target_node.full_path(directory_view.model()))
continue; continue;
auto new_path = String::format("%s/%s", auto new_path = String::format("%s/%s",
target_node.full_path(directory_view.model()).characters(), target_node.full_path(directory_view.model()).characters(),