RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-25 22:15:06 +00:00
Code Issues Activity Actions

LibJS: Cache a FlyString for "this" to speed up variable lookup

Browse source 
We were hitting strcmp() in every variable lookup to see if the lookup
was for "this". Caching a FlyString("this") turns that check into one
pointer comparison instead. :^)
This commit is contained in:
Andreas Kling 2020-04-12 20:40:02 +02:00
parent 26a8984d03
commit 110ca6b0b6
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibJS/Interpreter.cpp
View file

@ -158,7 +158,8 @@ void Interpreter::set_variable(const FlyString& name, Value value, bool first_as
Optional<Value> Interpreter::get_variable(const FlyString& name) Optional<Value> Interpreter::get_variable(const FlyString& name)
{ {
if (name == "this") static FlyString this_name = "this";
if (name == this_name)
return this_value(); return this_value();
for (ssize_t i = m_scope_stack.size() - 1; i >= 0; --i) { for (ssize_t i = m_scope_stack.size() - 1; i >= 0; --i) {