RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 06:57:46 +00:00
Code Issues Activity Actions

Shell: Auto-completion shouldn't suggest non-executable files for the program name

Browse source
This commit is contained in:
Gunnar Beutner 2021-04-20 16:17:38 +02:00 • committed by Andreas Kling
parent e45e0eeb47
commit 111ac4b1f4
3 changed files with 13 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Shell/AST.cpp
View file

@ -336,7 +336,7 @@ Vector<Line::CompletionSuggestion> Node::complete_for_editor(Shell& shell, size_
// If the literal isn't an option, treat it as a path.
if (!(text.starts_with("-") || text == "--" || text == "-"))
return shell.complete_path("", text, corrected_offset);
return shell.complete_path("", text, corrected_offset, Shell::ExecutableOnly::No);
// If the literal is an option, we have to know the program name
// should we have no way to get that, bail early.
@ -2349,7 +2349,7 @@ Vector<Line::CompletionSuggestion> PathRedirectionNode::complete_for_editor(Shel
if (corrected_offset > node->text().length())
return {};
return shell.complete_path("", node->text(), corrected_offset);
return shell.complete_path("", node->text(), corrected_offset, Shell::ExecutableOnly::No);
}
PathRedirectionNode::~PathRedirectionNode()
@ -2895,7 +2895,7 @@ Vector<Line::CompletionSuggestion> Juxtaposition::complete_for_editor(Shell& she
auto text = node->text().substring(1, node->text().length() - 1);
return shell.complete_path(tilde_value, text, corrected_offset - 1);
return shell.complete_path(tilde_value, text, corrected_offset - 1, Shell::ExecutableOnly::No);
}
return Node::complete_for_editor(shell, offset, hit_test_result);